You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/14 23:44:34 UTC
[GitHub] [arrow] MingyuZhong opened a new pull request #8190: Basic support of Decimal256.
MingyuZhong opened a new pull request #8190:
URL: https://github.com/apache/arrow/pull/8190
Includes Python light integration. The notable missing pieces are: rescaling (left some TODOs), cast (which blocks update of test_array.py), csv support, pandas, and integration with other languages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8190: Basic support of Decimal256 (PR for merging into decimal256 branch NOT master)
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8190:
URL: https://github.com/apache/arrow/pull/8190#issuecomment-692378087
> Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Per offline discussion, I think a JIRA to merge this into non-master is overkill but I'll create one if I encounter problems with the merge tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8190: Basic support of Decimal256 (PR for merging into decimal256 branch NOT master)
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8190:
URL: https://github.com/apache/arrow/pull/8190#issuecomment-693191522
Overall, this looks like a good first pass, that I think will unblock integration testing (I'll try to make add a proof of concepts C++ round trip integration test on Decimal256 branch this week).
I think there might potentially be some places where traits could be used to removed duplicate code via enable if, but I don't think that should block this check in. I'm going to merge to Decimal256 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8190: Basic support of Decimal256 (PR for merging into decimal256 branch NOT master)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8190:
URL: https://github.com/apache/arrow/pull/8190#issuecomment-692376513
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield merged pull request #8190: Basic support of Decimal256 (PR for merging into decimal256 branch NOT master)
Posted by GitBox <gi...@apache.org>.
emkornfield merged pull request #8190:
URL: https://github.com/apache/arrow/pull/8190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8190: Basic support of Decimal256 (PR for merging into decimal256 branch NOT master)
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8190:
URL: https://github.com/apache/arrow/pull/8190#issuecomment-692815181
I would suggest do the C++ side that and bother about Python later. We don't want the final PR to be too large for reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org