You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/09/10 00:36:57 UTC
[GitHub] [helix] micahstubbs opened a new pull request, #2209: 2206/helix-front node module
micahstubbs opened a new pull request, #2209:
URL: https://github.com/apache/helix/pull/2209
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fix #2206
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR adds the necessary configuration to publish helix-front as a node module on the npm package registry. This makes it easier to run helix-front in your own environment with custom configuration for your own Helix cluster.
### Tests
```
npm publish --dry-run
```
### Code Quality
- [x] My diff has been formatted using [Prettier](https://prettier.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 merged pull request #2209: 2206/helix-front node module
Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2209:
URL: https://github.com/apache/helix/pull/2209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2209: 2206/helix-front node module
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2209:
URL: https://github.com/apache/helix/pull/2209#issuecomment-1245672179
This PR is ready to be merged, approved by @somecodemonkey
Final commit message:
## helix-front node module(#2206)
Add config to publish helix-front as a node module
Do this to make it easier to run helix-front with custom config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] somecodemonkey commented on pull request #2209: 2206/helix-front node module
Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2209:
URL: https://github.com/apache/helix/pull/2209#issuecomment-1244708571
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] micahstubbs commented on pull request #2209: 2206/helix-front node module
Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2209:
URL: https://github.com/apache/helix/pull/2209#issuecomment-1245673575
The CI test failure appears to be a WAGED rebalance strategy flaky test unrelated to these frontend changes.
```
15731 [HelixController-pipeline-default-CLUSTER_TestDistControllerElection_testCompeteLeadership-(21bf4a16_DEFAULT)] ERROR org.apache.helix.controller.rebalancer.waged.WagedRebalancer [] - Failed to calculate the new assignments.
org.apache.helix.HelixRebalanceException: Failed to get the current baseline assignment because of unexpected error. Failure Type: INVALID_REBALANCER_STATUS
```
https://github.com/apache/helix/actions/runs/3026141070/jobs/4869251478#step:5:108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org