You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/08/14 22:52:43 UTC
[PR] fix(charts): fix Bubble chart crash and correct example's time_range to a year with real data [superset]
rusackas opened a new pull request, #43201:
URL: https://github.com/apache/superset/pull/43201
### SUMMARY
#43152 got squash-merged at its first commit's SHA, so the second commit (the actual crash fix) never landed on `master`. This PR carries that commit forward, rebased cleanly on current `master`.
Two real bugs, both from following up on the Bubble example's viz_type migration:
- `Bubble/transformProps.ts` set `xAxis.interval` at the axis level instead of nesting it under `xAxis.axisLabel.interval`. `interval` on the axis itself forces echarts' `IntervalScale` (numeric-tick mode), which crashes for a non-numeric x-axis - i.e. every real `bubble_v2` chart. Added a regression test (there was none before).
- The `Life_Expectancy_VS_Rural` example's `time_range` pointed at 2014, which has zero non-null `SP_DYN_LE00_IN` data in this dataset - the chart rendered with no bubbles even once the crash was fixed. Moved it to 2011, which has real data.
### TESTING INSTRUCTIONS
Load examples, open the "Life Expectancy VS Rural %" chart in `world_health` - it should render bubbles instead of crashing/showing empty. `npm run test -- transformProps.test.ts` under `plugin-chart-echarts` for the regression test.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(charts): fix Bubble chart crash and correct example's time_range to a year with real data [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43201:
URL: https://github.com/apache/superset/pull/43201#issuecomment-5299074085
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43201?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.82%. Comparing base ([`2eedc60`](https://app.codecov.io/gh/apache/superset/commit/2eedc609a808b4a22657c5a291bd5f389b437c74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2cee341`](https://app.codecov.io/gh/apache/superset/commit/2cee341cc8bf83596bfa45dcf76f4712067e004b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (2eedc60) and HEAD (2cee341). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (2eedc60) | HEAD (2cee341) |
>|------|------|------|
>|python|18|3|
>|presto|3|1|
>|hive|3|1|
>|unit|3|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43201 +/- ##
==========================================
- Coverage 66.64% 57.82% -8.83%
==========================================
Files 2873 2873
Lines 163628 163628
Branches 37767 37767
==========================================
- Hits 109052 94617 -14435
- Misses 52447 68122 +15675
+ Partials 2129 889 -1240
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.17% <ø> (ø)` | |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.76% <ø> (+<0.01%)` | :arrow_up: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.11% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.31% <ø> (-17.95%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/43201/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43201?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(charts): fix Bubble chart crash and correct example's time_range to a year with real data [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #43201:
URL: https://github.com/apache/superset/pull/43201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(charts): fix Bubble chart crash and correct example's time_range to a year with real data [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43201:
URL: https://github.com/apache/superset/pull/43201#issuecomment-5298943599
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org