[jira] Commented: (DERBY-1201) ResultSet.updateRow() in network client should not throw an exception if no fields in the row have been modified.

["Kathey Marsden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591071#action_12591071 ] 

Kathey Marsden commented on DERBY-1201:
---------------------------------------

I verified your fix with the repro, but am not totally sure about the code change. I would feel better if someone familiar with updatable ResultSets took a quick look.   A couple of general comments:
1) The indentation use of tabs/spaces does not seem to match the surrounding code.
2) We should add a regression test for this case.
3) Did you run tests with your patch?


> ResultSet.updateRow() in network client should not throw an exception if no fields in the row have been modified.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1201
>                 URL: https://issues.apache.org/jira/browse/DERBY-1201
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Newcomer
>    Affects Versions: 10.1.1.0, 10.1.2.1, 10.1.3.1, 10.2.1.6
>            Reporter: David Van Couvering
>            Assignee: Suran Jayathilaka
>            Priority: Minor
>         Attachments: derby-1201.diff, TestUpdateRow.java
>
>
> ResultSet.updateRow() in the network client throws an exception if no fields in the current row have been modified.  In the embedded client, the method silently does nothing in the same circumstances.  Although the spec is yet to go final, our understanding is that JDBC 4 spec indicates that the behavior of the embedded client is correct, so we should correct this in the network client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.