You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2019/10/04 13:07:00 UTC
[jira] [Comment Edited] (JCRVLT-382) DefaultWorkspaceFilter: Reset
source for every modifying operation
[ https://issues.apache.org/jira/browse/JCRVLT-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944464#comment-16944464 ]
Konrad Windszus edited comment on JCRVLT-382 at 10/4/19 1:06 PM:
-----------------------------------------------------------------
[~tripod] WDYT of this PR: https://github.com/apache/jackrabbit-filevault/pull/59/commits/0ff1c629d88556a2785e129bb3b75301cb90ff39
was (Author: kwin):
[~tripod] WDYT?
> DefaultWorkspaceFilter: Reset source for every modifying operation
> ------------------------------------------------------------------
>
> Key: JCRVLT-382
> URL: https://issues.apache.org/jira/browse/JCRVLT-382
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: vlt
> Affects Versions: 3.4.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: 3.4.2
>
>
> Currently the source is generated lazily only once, but once it is set it will not automatically be reset. I think it makes sense to automatically reset the underlying source whenever some write operation is called on the DefaultWorkspaceFilter, i.e. one of
> # {{add(...)}}
> # {{addPropertyFilterSet(...)}}
> Both {{setImportMode(...)}} and {{setGlobalIgnored(...)}} do not affect the serialization and therefore do not need to be considered here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)