[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

[onkarshedge <gi...@git.apache.org>]

Github user onkarshedge commented on the issue:

    https://github.com/apache/zeppelin/pull/1231
  
    @bzz Design help needed. Connect all the pieces...
    
    `TorrentEngine` - singleton enum . has methods to start,stop a session. download a torrent from a magnet link and seed a given input file. It also has a alertListener which receives alert updates and a TorrentEngineListener.
    
    `BittorrentNotebookRepo` - has a torrentEngine Instance and a list of TorrentSocket  connections, To receive messages and send to each websocket. It implements the TorrentEngineListener.  
    
    Should this be separate or included in [NotebookServer OnMessage](https://github.com/apache/zeppelin/blob/73f1e485936918817386e344adebc9a721eaa5fa/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L156)
    
    `TorrentSocket `- has an BittorrentNotebookRepo Instance. How to pass an instance to it ? . It could be passed via WebSocketCreator.I read [here](http://www.eclipse.org/jetty/documentation/9.1.5.v20140505/jetty-websocket-server-api.html) but then BittorrentNotebookRepo would have to extend `WebSocketServlet` and it already extends `VFSNotebookRepo`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---