You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "JIAN ZHOU (JIRA)" <ji...@apache.org> on 2015/01/16 23:46:34 UTC

[jira] [Commented] (STORM-627) Storm-hbase configuration error

    [ https://issues.apache.org/jira/browse/STORM-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280939#comment-14280939 ] 

JIAN ZHOU commented on STORM-627:
---------------------------------

I created a pull request. https://github.com/apache/storm/pull/384 

> Storm-hbase configuration error
> -------------------------------
>
>                 Key: STORM-627
>                 URL: https://issues.apache.org/jira/browse/STORM-627
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-hbase
>    Affects Versions: 0.9.3
>            Reporter: JIAN ZHOU
>            Assignee: JIAN ZHOU
>
> The HBaseMapState and HBaseState classes are not reading the configuration entries properly. The code reads from the "map" entries instead of the "conf" entries in the code referenced below, which is incorrect.
> Details and suggested fix:
> org/apache/storm/hbase/trident/state/HBaseMapState.java
> line 78:
> -- hbConfig.set(key, String.valueOf(map.get(key)));
> ++ hbConfig.set(key, String.valueOf(conf.get(key)));
> org/apache/storm/hbase/trident/state/HBaseState.java
> line 108:
> -- hbConfig.set(key, String.valueOf(map.get(key)));
> ++ hbConfig.set(key, String.valueOf(conf.get(key)));
> Note: it seems that a similar bug was fixed in a different file in ptgoetz/storm-hbase (https://github.com/ptgoetz/storm-hbase/commit/39797ac6914d042051d6f4504edb6e01998bccf3), but these two java files still have it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)