You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/04/21 17:36:00 UTC

[jira] [Commented] (CALCITE-3944) Move dumpSets and dumpGraphviz out of VolcanoPlanner

    [ https://issues.apache.org/jira/browse/CALCITE-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088898#comment-17088898 ] 

Julian Hyde commented on CALCITE-3944:
--------------------------------------

If they’re static - and no one besides them needs to create a visitor object or whatever - put them in a util class with a plural name. Easier to invoke from a debugger, etc.

> Move dumpSets and dumpGraphviz out of VolcanoPlanner
> ----------------------------------------------------
>
>                 Key: CALCITE-3944
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3944
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> They are helper methods, will move to Dumper.java.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)