[GitHub] [hadoop] iwasakims commented on a diff in pull request #4174: HADOOP-18203. Backport HADOOP-15033 to branch-2.10.

[GitBox <gi...@apache.org>]

iwasakims commented on code in PR #4174:
URL: https://github.com/apache/hadoop/pull/4174#discussion_r853767603


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java:
##########
@@ -89,6 +89,21 @@ public static boolean isJava7OrAbove() {
     return true;
   }
 
+  // "1.8"->8, "9"->9, "10"->10
+  private static final int JAVA_SPEC_VER = Math.max(8, Integer.parseInt(
+      System.getProperty("java.specification.version").split("\\.")[0]));

Review Comment:
   JAVA_SPEC_VER is set to 8 even on Java 7. Can we cover Java 7 here? If not, we should have a comment for justification at least.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org