You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/07/14 04:57:00 UTC

[echarts] branch dataset-perf updated (0349b87 -> 325a5c9)

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch dataset-perf
in repository https://gitbox.apache.org/repos/asf/echarts.git.


    from 0349b87  refact(data): fix type from dataset may incorrect.
     new e9e6077  refact(data): fix storage clone lost indices.
     add 2d01681  fix(type): there is no polarIndex when coordinate of series is polar
     add d35dda0  fix: add polarId and rm useless type
     add d5a7424  Merge pull request #15281 from Map1en/fix-type-polarIndex-when-coord-is-polar
     add eba8fb4  fix(bar): set label to be inside when position is middle
     add 2f44a15  fix: use position on itemModel
     add 1e36890  Merge pull request #15309 from apache/fix-bar-middle
     add e0bc363  fix(gauge): guage detail label should be on top
     add fca2cb7  Merge pull request #15326 from susiwen8/gauge-label-z
     add 6bd27bf  Fix(polar): polar would throw error if no label
     add 80fa130  Fix: should not return directly
     add ccabde4  chore: bar label type enhance
     add cf26691  Merge pull request #15314 from susiwen8/polar-bar-label
     add ff0c8d3  feat(effectScatter): make ripple effect count configurable, resolves #15252.
     add 2efe31d  fix(effectScatter): recreate effect if count changed.
     add e339203  refactor(effectScatter): rename `count` to `number`.
     add dc9af24  Merge pull request #15335 from apache/feat-ripple-effect-count
     add 682ff91  enable pointer's z-level adjustment in gauge chart & set default z-level above detail and title
     add eaf1ee4  Merge pull request #15337 from AmosChenYQ/enable-level-adjustment-in-gauge-chart
     new 325a5c9  Merge branch 'master' into dataset-perf

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/chart/bar/BarSeries.ts                     |  2 +-
 src/chart/bar/BarView.ts                       |  9 +++++----
 src/chart/effectScatter/EffectScatterSeries.ts |  6 ++++--
 src/chart/gauge/GaugeSeries.ts                 |  5 +++++
 src/chart/gauge/GaugeView.ts                   |  4 ++++
 src/chart/helper/EffectSymbol.ts               | 14 +++++++-------
 src/chart/helper/SymbolDraw.ts                 |  7 ++++++-
 src/data/DataStorage.ts                        | 10 +++++-----
 src/util/types.ts                              |  7 ++-----
 test/effectScatter.html                        |  9 +++++++--
 10 files changed, 46 insertions(+), 27 deletions(-)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 01/02: refact(data): fix storage clone lost indices.

Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch dataset-perf
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit e9e6077c0a7a6496034793c354c0336a7e2a33e2
Author: pissang <bm...@gmail.com>
AuthorDate: Wed Jul 14 12:55:45 2021 +0800

    refact(data): fix storage clone lost indices.
---
 src/data/DataStorage.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/data/DataStorage.ts b/src/data/DataStorage.ts
index 01574ec..7c9322a 100644
--- a/src/data/DataStorage.ts
+++ b/src/data/DataStorage.ts
@@ -796,7 +796,7 @@ class DataStorage {
      */
     map(dims: DimensionIndex[], cb: MapCb): DataStorage {
         // TODO only clone picked chunks.
-        const target = this.clone(dims, true);
+        const target = this.clone(dims);
         const targetChunks = target._chunks;
 
 
@@ -854,7 +854,7 @@ class DataStorage {
         valueDimension: DimensionIndex,
         rate: number
     ) {
-        const target = this.clone([valueDimension]);
+        const target = this.clone([valueDimension], true);
         const targetStorage = target._chunks;
         const dimStore = targetStorage[valueDimension];
         const len = this.count();
@@ -941,7 +941,7 @@ class DataStorage {
         sampleValue: (frameValues: ArrayLike<ParsedValue>) => ParsedValueNumeric,
         sampleIndex: (frameValues: ArrayLike<ParsedValue>, value: ParsedValueNumeric) => number
     ): DataStorage {
-        const target = this.clone([dimension]);
+        const target = this.clone([dimension], true);
         const targetStorage = target._chunks;
 
         const frameValues = [];
@@ -1108,7 +1108,7 @@ class DataStorage {
      *
      * @param clonedDims Determine which dims to clone. Will share the data if not specified.
      */
-    clone(clonedDims?: number[], cloneIndices?: boolean): DataStorage {
+    clone(clonedDims?: number[], ignoreIndices?: boolean): DataStorage {
         const target = new DataStorage();
         const chunks = this._chunks;
         const clonedDimsMap = clonedDims && reduce(clonedDims, (obj, dimIdx) => {
@@ -1128,7 +1128,7 @@ class DataStorage {
         }
         this._copyCommonProps(target);
 
-        if (cloneIndices) {
+        if (!ignoreIndices) {
             target._indices = this._cloneIndices();
         }
         target._updateGetRawIdx();

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 02/02: Merge branch 'master' into dataset-perf

Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch dataset-perf
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 325a5c950b69d0bede66c33bf32ffa46aaafb287
Merge: e9e6077 eaf1ee4
Author: pissang <bm...@gmail.com>
AuthorDate: Wed Jul 14 12:56:19 2021 +0800

    Merge branch 'master' into dataset-perf

 src/chart/bar/BarSeries.ts                     |  2 +-
 src/chart/bar/BarView.ts                       |  9 +++++----
 src/chart/effectScatter/EffectScatterSeries.ts |  6 ++++--
 src/chart/gauge/GaugeSeries.ts                 |  5 +++++
 src/chart/gauge/GaugeView.ts                   |  4 ++++
 src/chart/helper/EffectSymbol.ts               | 14 +++++++-------
 src/chart/helper/SymbolDraw.ts                 |  7 ++++++-
 src/util/types.ts                              |  7 ++-----
 test/effectScatter.html                        |  9 +++++++--
 9 files changed, 41 insertions(+), 22 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org