You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2018/12/19 23:41:50 UTC

[GitHub] nwangtw commented on a change in pull request #3129: ByteAmount String Format

nwangtw commented on a change in pull request #3129: ByteAmount String Format
URL: https://github.com/apache/incubator-heron/pull/3129#discussion_r243114551
 
 

 ##########
 File path: heron/common/src/java/org/apache/heron/common/basics/ByteAmount.java
 ##########
 @@ -23,12 +23,15 @@
  * Class that encapsulates number of bytes, with helpers to handle units properly.
  */
 public final class ByteAmount implements Comparable<ByteAmount> {
+  private static final long KB = 1024L;
   private static final long MB = 1024L * 1024;
 
 Review comment:
   "KB * 1024" might be better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services