[GitHub] [spark] cloud-fan commented on a change in pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27936: [SPARK-31171][SQL] size(null) should return null under ansi mode
URL: https://github.com/apache/spark/pull/27936#discussion_r393815855
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -3014,7 +3014,10 @@ class SQLConf extends Serializable with Logging {
 
   def csvColumnPruning: Boolean = getConf(SQLConf.CSV_PARSER_COLUMN_PRUNING)
 
-  def legacySizeOfNull: Boolean = getConf(SQLConf.LEGACY_SIZE_OF_NULL)
+  def legacySizeOfNull: Boolean = {
+    // size(null) should return null under ansi mode.
+    getConf(SQLConf.LEGACY_SIZE_OF_NULL) && !getConf(ANSI_ENABLED)
 
 Review comment:
   This is the first one, and I don't think we need a migration guide as the behavior doesn't change by default.
   
   I'll update the config doc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org