You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/02/13 20:38:55 UTC

[impala] 01/01: Remove some noisier clang-tidy rules

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to reference refs/for/master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit b2f305c0029ecc96015bd655fff47bebee286ace
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Wed Feb 13 12:36:26 2019 -0800

    Remove some noisier clang-tidy rules
    
    These rules generate a lot of warnings and generally aren't
    considered best practices in our codebase.
    
    This may help a bit with IMPALA-7993.
    
    Change-Id: I12d61dccff0f9772165c10238ae178208a100706
---
 .clang-tidy | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index bf37d7a..24f14a0 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -30,7 +30,6 @@ Checks: "-*,clang*,\
 -clang-analyzer-unix.Malloc,\
 -clang-analyzer-unix.MallocSizeof,\
 -clang-diagnostic-c++1z-extensions,\
--clang-diagnostic-c++98*,\
 -clang-diagnostic-cast-align,\
 -clang-diagnostic-class-varargs,\
 -clang-diagnostic-conversion,\
@@ -51,8 +50,6 @@ Checks: "-*,clang*,\
 -clang-diagnostic-nested-anon-types,\
 -clang-diagnostic-old-style-cast,\
 -clang-diagnostic-overlength-strings,\
--clang-diagnostic-packed,\
--clang-diagnostic-padded,\
 -clang-diagnostic-return-type-c-linkage,\
 -clang-diagnostic-shadow,\
 -clang-diagnostic-shadow-field-in-constructor,\
@@ -69,7 +66,6 @@ Checks: "-*,clang*,\
 -clang-diagnostic-unused-parameter,\
 -clang-diagnostic-used-but-marked-unused,\
 -clang-diagnostic-vla-extension,\
--clang-diagnostic-weak-vtables"
 
 # Ignore warnings in gutil