You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2017/11/25 13:31:25 UTC
[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering
ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering
URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153045848
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##########
@@ -79,7 +85,8 @@
static final int REMOTE_MASK = 0x04 << 24;
static final int REMOTE_FAIL_MASK = 0x08 << 24;
static final int READ_ONLY_MASK = 0x10 << 24;
- static final int UNAVAIL_MASK = 0x20 << 24;
+ static final int SLOW_MASK = 0x20 << 24;
+ static final int UNAVAIL_MASK = 0x40 << 24;
Review comment:
No, the order is important, since candidate bookies are sorted by these masks. You want to select a slow bookie before an unavailable one. You probably want to select a slow bookie before a readonly bookie too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services