You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/11/06 06:30:16 UTC
[GitHub] zeppelin pull request #1605: [ZEPPELIN-1622] Remove %dep interpreter depreca...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1605
[ZEPPELIN-1622] Remove %dep interpreter deprecated message
### What is this PR for?
%dep interpreter was going to be deprecated, but we had feedback from many users that this feature provide different advantage over dependency loading via GUI so we want to keep supporting it. This PR remove deprecated message when users use %dep interpreter.
### What type of PR is it?
Documentation
### What is the Jira issue?
[ZEPPELIN-1622](https://issues.apache.org/jira/browse/ZEPPELIN-1622)
### How should this be tested?
Run %dep interpreter such as `z.load('/your/library.jar)` and see if deprecated message is gone.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1605
----
commit 4617cbfbbb3f035d831a2dd4ed036dd638cbd4f9
Author: Mina Lee <mi...@apache.org>
Date: 2016-11-06T06:12:32Z
Remove %dep interpreter deprecated message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1605: [ZEPPELIN-1622] Remove %dep interpreter depreca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1605
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1605: [ZEPPELIN-1622] Remove %dep interpreter deprecated mes...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1605
@bzz @Leemoonsoo Ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1605: [WIP][ZEPPELIN-1622] Remove %dep interpreter deprecate...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1605
Looks great to me, thank you @minahlee for cleaning up in order to avoiding user confusion!
\U0001f4af for having a test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1605: [ZEPPELIN-1622] Remove %dep interpreter deprecated mes...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1605
@minahlee Thanks for the update and unittest.
LGTM and merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1605: [WIP][ZEPPELIN-1622] Remove %dep interpreter deprecate...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1605
@bzz @Leemoonsoo thank you for review! I will fix test to use `%dep`, I need to make time to fix it :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---