You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Tianqi Chen <no...@github.com.INVALID> on 2022/08/30 14:45:19 UTC

[apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Dear community:

This is a formal vote on [TVM unity connection technical strategy](https://github.com/apache/tvm-rfcs/pull/91). We had great discussions and feedback in the [discuss thread](https://discuss.tvm.apache.org/t/establish-tvm-unity-connection-a-technical-strategy/13344) 

Please vote

Vote:
+1
0 - I don't feel strongly about it, but don't object
-1 - because..

The VOTE will open for a week.

This thread is mirrored to dev@, please vote by replying to this thread



-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Junru Shao <no...@github.com.INVALID>.
+1 (binding)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233389506
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by lxiongh <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1580241797
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Andrew Reusch <no...@github.com.INVALID>.
-1 (binding veto)

I agree with @leandron that Establish TVM Unity Connection Technical Strategy RFC is heavily centered around Relax RFC. Additionally, while this RFC stops short of endorsing the Relax RFC as the future direction of TVM, it very [explicitly discusses](https://github.com/apache/tvm-rfcs/blob/d06a72546b8d169da354c5796ca250baca9970e4/rfcs/0091-establish-tvm-unity-connection.md#evolving-default-build) those aspirations. Therefore I do not agree that this RFC is separate from Relax RFC and therefore do not think a VOTE thread is appropriate at this time.

I want to be clear that I am not disagreeing with the technical direction here, but that I don't believe it is yet time to VOTE. I would happily change my vote should more consensus develop in the community.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233159746
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Cody Yu <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1234673189
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Lesheng Jin <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233603370
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Yaxing Cai <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233605463
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Matthew Barrett <no...@github.com.INVALID>.
+1

I'd love for us to have more clarity on the future of Relax and Relay, but I don't think vetoing this proposal is now progressing that goal any further. Instead, we're seeing substantial fracturing in the development community, with a number of branches and forks (including production repos) spinning up to support Relax-related efforts. This pulls mindshare and resources away from the main repo (CI/testing/fixes/documentation), ultimately to the detriment of anyone still working there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1421236617
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Ziheng Jiang <no...@github.com.INVALID>.
+1 (binding)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1235948052
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Yuanjing Shi <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1255424901
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Jiawei Liu <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1234665621
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Andrew Reusch <no...@github.com.INVALID>.
0

Ultimately I'd prefer to get more clarity on this direction, but given we are getting that through the new `unity` branch, it makes sense to adopt this proposal as the "goal" given that progress on the unity branch will further illuminate the details.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1421278930
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Christopher Sidebottom <no...@github.com.INVALID>.
0

Does this vote serve any purpose given the `unity` work is continuing regardless of the outcome?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1422361628
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Tianqi Chen <no...@github.com.INVALID>.
Thank you @leandron . As per stated in the beginning, this RFC establishes a strategy to introduce an optional module to TVM, which as of now is minimally disruptive to the current infrastructure. 

We also consider it as as a separate RFC from the relax RFC it sets up the overall technical strategies. It also reflects our previous sequence of [communications](https://tvm.apache.org/2021/12/15/tvm-unity) and [discussions](https://discuss.tvm.apache.org/t/relax-co-designing-high-level-abstraction-towards-tvm-unity/12496) in the community 

I would encourage us to scope the technical reasonings to the scope of the RFC. Note that most of the strategy RFC describes the optional module state, and possible future opportunities. While I fully agree that some of the possible future actions(e.g. change of a default flow) would warrant more in-depth discussions of their own and are helpful to setup a context, they are not necessarily reasons to block the RFC that do not yet propose to make such changes. 

This being said, you are more than welcomed to bring technical comments on the [discussion thread](https://discuss.tvm.apache.org/t/establish-tvm-unity-connection-a-technical-strategy/13344) or RFC as well, so we can continue to discuss concrete items on this RFC. Having clear technical reasonings would help us to move things forward and bring consensus together. 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233048896
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Sunghyun Park <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232286842
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Wuwei Lin <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1231979807
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Ruihang Lai <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1231919264
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Tianqi Chen <no...@github.com.INVALID>.
Thanks @areusch , the particular section that you described was explicitly listed as "future opportunities" and is not part of the RFC which may or may not be executed. As per stated in the text 

```
This section describes possible approaches to evolve the default build to leverage more of unity components. Note again that this is only a discussion of possible approach is not part of the RFC, but only to bring possible relevant context of future opportunities.
The detailed discussions about the exact approach shall happen in dedicated RFCs for each incremental change to the default build.
```



-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233166870
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Ziheng Jiang <zi...@apache.org>.
+1

On Tue, Aug 30, 2022 at 08:05 Yuchen Jin <no...@github.com.invalid>
wrote:

> +1
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/tvm/issues/12651#issuecomment-1231796765
> You are receiving this because you are subscribed to this thread.
>
> Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Yuchen Jin <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1231796765
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Chris Sullivan <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1423091637
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Zhao Wu <no...@github.com.INVALID>.
+1 (binding)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1266327470
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Zihao Ye <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232109906
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Chris Sullivan <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232278471
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Yong Wu <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232590059
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Tianqi Chen <no...@github.com.INVALID>.
We decided to withdraw the proposal https://github.com/apache/tvm-rfcs/pull/91#issuecomment-1693532638

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1693536158
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Siyuan Feng <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1231816769
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Leandro Nunes <no...@github.com.INVALID>.
-1 (binding veto)

There is overlap with what is being proposed here being a superset of what is under active discussion in the Relax RFC at https://github.com/apache/tvm-rfcs/pull/89, so I don't think that we can make an informed decision in this RFC, until the discussion in the Relax RFC are settled and we decide on whether it is accepted or not. For that decision to happen, the specific/actionable questions need to be answered.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232876396
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Junru Shao <no...@github.com.INVALID>.
+1 (binding)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1231808637
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by masahi <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1232578723
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by xqdan <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233949370
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Cody Yu <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1581123455
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Xiyou Zhou <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233388156
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Bohan Hou <no...@github.com.INVALID>.
+1

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233667253
You are receiving this because you commented.

Message ID: <ap...@github.com>

Re: [apache/tvm] [VOTE] Establish TVM Unity Connection Technical Strategy (Issue #12651)

Posted by Tianqi Chen <no...@github.com.INVALID>.
Closed #12651 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#event-10194231607
You are receiving this because you commented.

Message ID: <ap...@github.com>