You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/01 05:28:03 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31684: [SPARK-34571][SQL][CORE] Provide a more convenient way to deprecate/remove/alternate configs

HyukjinKwon commented on a change in pull request #31684:
URL: https://github.com/apache/spark/pull/31684#discussion_r584454006



##########
File path: core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala
##########
@@ -205,6 +206,23 @@ private[spark] case class ConfigBuilder(key: String) {
     this
   }
 
+  def deprecated(version: String, deprecationMessage: String): ConfigBuilder = {
+    LegacyConfigsRegister.registerDeprecated(key, version, deprecationMessage)
+    this
+  }
+
+  def alternated(

Review comment:
       nit but `alternated` -> `alternative`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org