You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (JIRA)" <ji...@apache.org> on 2012/05/18 01:01:07 UTC
[jira] [Created] (HBASE-6043) Add Increment Coalescing to thrift.
Elliott Clark created HBASE-6043:
------------------------------------
Summary: Add Increment Coalescing to thrift.
Key: HBASE-6043
URL: https://issues.apache.org/jira/browse/HBASE-6043
Project: HBase
Issue Type: Improvement
Reporter: Elliott Clark
Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-6.patch
More comments and turn the default to off.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285377#comment-13285377 ]
Hudson commented on HBASE-6043:
-------------------------------
Integrated in HBase-TRUNK #2950 (See [https://builds.apache.org/job/HBase-TRUNK/2950/])
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344086)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescerMBean.java
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch, HBASE-6043-ADD.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-3.patch
updating to keep up with phabricator.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Summary: Add Increment Coalescing in thrift. (was: Add Increment Coalescing to thrift.)
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281961#comment-13281961 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528780/HBASE-6043-5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.replication.TestMasterReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1969//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1969//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1969//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-0.patch
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-1.patch
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark reassigned HBASE-6043:
------------------------------------
Assignee: Elliott Clark
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282080#comment-13282080 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528811/HBASE-6043-6.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1975//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1975//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1975//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285603#comment-13285603 ]
Hudson commented on HBASE-6043:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #32 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/32/])
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344086)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescerMBean.java
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch, HBASE-6043-ADD.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282084#comment-13282084 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528822/HBASE-6043-9.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1976//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1976//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1976//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285270#comment-13285270 ]
Hudson commented on HBASE-6043:
-------------------------------
Integrated in HBase-TRUNK #2947 (See [https://builds.apache.org/job/HBase-TRUNK/2947/])
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344043)
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344034)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescerMBean.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* /hbase/trunk/hbase-server/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-4.patch
Smaller sleep for the tests. I ran it 20 times and never saw a failure. Not sure why I needed the 6 seconds before but seems like this is long enough.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-5.patch
Added comments about potential data loss if thrift server crashes with coalescing increment turned on.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285245#comment-13285245 ]
stack commented on HBASE-6043:
------------------------------
The patch added new files to src instead of to hbase-server/src. I just fixed this.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: (was: HBASE-6043-ADD.patch)
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-8.patch
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-ADD.patch
Add header for files to make rat happy.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285277#comment-13285277 ]
Hudson commented on HBASE-6043:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #31 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/31/])
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344043)
HBASE-6043 Add Increment Coalescing in thrift. (Revision 1344034)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/IncrementCoalescerMBean.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* /hbase/trunk/hbase-server/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-9.patch
Turn on coalescing in the tests so taht is tested well.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-ADD.patch
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch, HBASE-6043-ADD.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-7.patch
Missed a default
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280676#comment-13280676 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528534/HBASE-6043-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1953//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1953//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281905#comment-13281905 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528771/HBASE-6043-4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1966//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1966//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1966//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280657#comment-13280657 ]
Elliott Clark commented on HBASE-6043:
--------------------------------------
Looks like those tests are failing on trunk right now.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-10.patch
Copy of what's on phabricator.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285360#comment-13285360 ]
stack commented on HBASE-6043:
------------------------------
I applied the addendum to trunk. Thanks Elliott.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch, HBASE-6043-ADD.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Attachment: HBASE-6043-2.patch
Trying to keep the patches up to date with whats on phabricator.
Addressed comments by JD.
Added stats.
Moved creation of increments into a ThriftUtilies.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281250#comment-13281250 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528654/HBASE-6043-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1959//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1959//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1959//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch, HBASE-6043-3.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280643#comment-13280643 ]
Hadoop QA commented on HBASE-6043:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528531/HBASE-6043-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 35 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.replication.TestMasterReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1952//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1952//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1952//console
This message is automatically generated.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-2.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6043:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Elliott.
(This patch has been running at SU for ~ a year now)
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-6043-0.patch, HBASE-6043-1.patch, HBASE-6043-10.patch, HBASE-6043-2.patch, HBASE-6043-3.patch, HBASE-6043-4.patch, HBASE-6043-5.patch, HBASE-6043-6.patch, HBASE-6043-7.patch, HBASE-6043-8.patch, HBASE-6043-9.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280440#comment-13280440 ]
Elliott Clark commented on HBASE-6043:
--------------------------------------
Not sure why Phabricator isn't posting diffs but the review is up at https://reviews.facebook.net/D3315.
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6043) Add Increment Coalescing in thrift.
Posted by "Elliott Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliott Clark updated HBASE-6043:
---------------------------------
Status: Patch Available (was: Open)
> Add Increment Coalescing in thrift.
> -----------------------------------
>
> Key: HBASE-6043
> URL: https://issues.apache.org/jira/browse/HBASE-6043
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6043-0.patch
>
>
> Since the thrift server uses the client api reducing the number of rpc's greatly speeds up increments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira