You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/08 10:12:28 UTC
[GitHub] [trafficserver] ema opened a new pull request #8393: Add stats for exceeded concurrency stream limits
ema opened a new pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393
Introduce two new stats tracking exceeded stream concurrency limits for
both inbound and outbount streams, respectively
proxy.process.http2.max_concurrent_inbound_streams_exceeded and
proxy.process.http2.max_concurrent_outbound_streams_exceeded
See https://datatracker.ietf.org/doc/html/rfc7540#section-5.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r727560566
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
I can't see the "reopen" button either 😞 Anyway, thanks for update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938645331
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ema closed pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ema closed pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938647420
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r727560566
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
I can't see the "reopen" button either 😞 Anyway, thanks for update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938691808
[approve ci docs]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938645496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938694715
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ema commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ema commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r725937651
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
Ah yes, I see that there are currently no metrics using (1) `inbound` / `outbound`.
I also see no `origin` version of `proxy.process.http2.current_client_connections`, ie: there's no `proxy.process.http2.current_origin_connections`, so maybe let's not use (2).
Given that there's no distinction for the streams exceeded metrics between requests and responses, we should avoid (4) too.
By exclusion, that leaves us with (3): `proxy.process.http2.max_concurrent_streams_exceeded_(in|out)`.
Let me know if that's fine with you and I'll update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ema commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ema commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r726855796
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
I amended my change, force-pushed, and now Github automatically closed the PR for some reason :sob: . Given that I don't seem to have the rights to reopen this one I've opened a new one: https://github.com/apache/trafficserver/pull/8409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938669135
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 removed a comment on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 removed a comment on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938669135
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 removed a comment on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 removed a comment on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938677301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938645496
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938677301
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r726622336
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
(3) looks good. It has consistency with the config (`proxy.config.http2.max_concurrent_streams_in`) too :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r725710684
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
It's bike shedding, but we need to discuss naming convention. We'll have HTTP/2 origin session support eventually and have more metrics for it.
There're several options.
1. `proxy.process.http2.XXX_(inbound|outbound)_YYY`
2. `proxy.process.http2.XXX_(client|origin)_YYY`
- e.g. `proxy.process.http2.current_client_connections`
3. `proxy.process.http2.XXX_(in|out)`
- e.g. `proxy.process.net.connections_throttled_(in|out)`
4. `proxy.process.http2.(incoming|outgoing)_XXX`
- e.g. `proxy.process.http.(incoming|outgoing)_requests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a change in pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on a change in pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#discussion_r725710684
##########
File path: doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
##########
@@ -256,3 +256,17 @@ HTTP/2
Represents the total number of closed HTTP/2 connections for not reaching the
minimum average window increment limit which is configured by
:ts:cv:`proxy.config.http2.min_avg_window_update`.
+
+.. ts:stat:: global proxy.process.http2.max_concurrent_inbound_streams_exceeded integer
Review comment:
It's bike shedding, but we need to discuss about naming convention. We'll have HTTP/2 origin session support eventually and have more metrics for it.
There're several options.
1. `proxy.process.http2.XXX_(inbound|outbound)_YYY`
2. `proxy.process.http2.XXX_(client|origin)_YYY`
- e.g. `proxy.process.http2.current_client_connections`
3. `proxy.process.http2.XXX_(in|out)`
- e.g. `proxy.process.net.connections_throttled_(in|out)`
4. `proxy.process.http2.(incoming|outgoing)_XXX`
- e.g. `proxy.process.http.(incoming|outgoing)_requests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938647420
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8393: Add stats for exceeded concurrency stream limits
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8393:
URL: https://github.com/apache/trafficserver/pull/8393#issuecomment-938645243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org