You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/11/11 11:02:08 UTC

[isis] branch master updated: ISIS-2877: improve guard message

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e30467  ISIS-2877: improve guard message
8e30467 is described below

commit 8e304675bf33cb216987b759dbf4b8575f70a13d
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Nov 11 12:02:00 2021 +0100

    ISIS-2877: improve guard message
---
 .../metamodel/interactions/managed/ParameterNegotiationModel.java    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/interactions/managed/ParameterNegotiationModel.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/interactions/managed/ParameterNegotiationModel.java
index 0deebc0..b6c9df2 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/interactions/managed/ParameterNegotiationModel.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/interactions/managed/ParameterNegotiationModel.java
@@ -101,11 +101,12 @@ public class ParameterNegotiationModel {
 
     @NonNull public Can<ManagedObject> getParamValues() {
         return paramModels.stream()
-                .peek(x->System.err.printf("\tparam[%d]%s%n", x.getParamNr(), x.getValue().getValue()))
                 .map(ParameterModel::getValue)
                 .map(Bindable::getValue)
+                // guard against framework bugs
                 .peek(managedObj->Objects.requireNonNull(managedObj, ()->
-                        String.format("param wrapper cannot be null %s", "?")))
+                        String.format("Internal Error: Parameter value adapter must not be null in %s",
+                                managedAction.getAction().getFeatureIdentifier())))
                 .collect(Can.toCan());
     }