You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/12/04 06:07:37 UTC

[GitHub] [incubator-tubemq] duli559 opened a new pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

duli559 opened a new pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342


   There is a issue when creating table source sink factory instance, fixed it with this pr.
   Jira link: https://issues.apache.org/jira/browse/TUBEMQ-437


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342#discussion_r535863095



##########
File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tubemq/TubemqTableSourceSinkFactory.java
##########
@@ -69,6 +69,10 @@
 
     private static final String SPLIT_COMMA = ",";
 
+    public static TubemqTableSourceSinkFactory getInstance() {

Review comment:
       Why not directly change the class object to public if you want to use the singleton mode?
   
   If it is not used as a singleton mode, I feel that the modification plan mentioned on the issue will be better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] aloyszhang commented on pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342#issuecomment-738592654


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] codecov-io commented on pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342#issuecomment-738693643


   # [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=h1) Report
   > Merging [#342](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=desc) (2694a5c) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/39962bcccd1a25da3c39b5b326dec4be992f362f?el=desc) (39962bc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tubemq/pull/342/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2)](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #342      +/-   ##
   ===========================================
   - Coverage      8.02%   7.92%   -0.10%     
   - Complexity      466     468       +2     
   ===========================================
     Files           249     255       +6     
     Lines         27115   27410     +295     
     Branches       4440    4480      +40     
   ===========================================
   - Hits           2176    2173       -3     
   - Misses        24468   24765     +297     
   - Partials        471     472       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...onnectors/tubemq/TubemqTableSourceSinkFactory.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmxpbmsvY29ubmVjdG9ycy90dWJlbXEvVHViZW1xVGFibGVTb3VyY2VTaW5rRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ava/org/apache/flink/connectors/tubemq/Tubemq.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmxpbmsvY29ubmVjdG9ycy90dWJlbXEvVHViZW1xLmphdmE=) | `81.81% <0.00%> (-7.84%)` | `8.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `51.42% <0.00%> (-4.00%)` | `14.00% <0.00%> (ø%)` | |
   | [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `2.47% <0.00%> (-0.79%)` | `8.00% <0.00%> (ø%)` | |
   | [...rg/apache/tubemq/client/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9jb25maWcvQ29uc3VtZXJDb25maWcuamF2YQ==) | `22.85% <0.00%> (ø)` | `4.00% <0.00%> (ø%)` | |
   | [...e/tubemq/server/broker/web/BrokerAdminServlet.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Jyb2tlckFkbWluU2VydmxldC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...tubemq/server/master/web/handler/WebApiMapper.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2hhbmRsZXIvV2ViQXBpTWFwcGVyLmphdmE=) | | | |
   | [...pache/tubemq/server/common/fielddef/CliArgDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvQ2xpQXJnRGVmLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [.../tubemq/server/common/webbase/WebMethodMapper.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vd2ViYmFzZS9XZWJNZXRob2RNYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=footer). Last update [39962bc...5958aad](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] codecov-io edited a comment on pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342#issuecomment-738693643


   # [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=h1) Report
   > Merging [#342](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=desc) (5958aad) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/39962bcccd1a25da3c39b5b326dec4be992f362f?el=desc) (39962bc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tubemq/pull/342/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2)](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #342      +/-   ##
   ===========================================
   - Coverage      8.02%   7.95%   -0.08%     
   - Complexity      466     468       +2     
   ===========================================
     Files           249     255       +6     
     Lines         27115   27410     +295     
     Branches       4440    4480      +40     
   ===========================================
   + Hits           2176    2180       +4     
   - Misses        24468   24759     +291     
     Partials        471     471              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...onnectors/tubemq/TubemqTableSourceSinkFactory.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmxpbmsvY29ubmVjdG9ycy90dWJlbXEvVHViZW1xVGFibGVTb3VyY2VTaW5rRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ava/org/apache/flink/connectors/tubemq/Tubemq.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmxpbmsvY29ubmVjdG9ycy90dWJlbXEvVHViZW1xLmphdmE=) | `81.81% <0.00%> (-7.84%)` | `8.00% <0.00%> (ø%)` | |
   | [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `2.47% <0.00%> (-0.79%)` | `8.00% <0.00%> (ø%)` | |
   | [...rg/apache/tubemq/client/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9jb25maWcvQ29uc3VtZXJDb25maWcuamF2YQ==) | `22.85% <0.00%> (ø)` | `4.00% <0.00%> (ø%)` | |
   | [...e/tubemq/server/broker/web/BrokerAdminServlet.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Jyb2tlckFkbWluU2VydmxldC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...tubemq/server/master/web/handler/WebApiMapper.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2hhbmRsZXIvV2ViQXBpTWFwcGVyLmphdmE=) | | | |
   | [...ache/tubemq/server/common/utils/ProcessResult.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvUHJvY2Vzc1Jlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...e/tubemq/server/broker/web/AbstractWebHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9icm9rZXIvd2ViL0Fic3RyYWN0V2ViSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...che/tubemq/server/common/webbase/WebFieldType.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vd2ViYmFzZS9XZWJGaWVsZFR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...che/tubemq/server/common/fielddef/WebFieldDef.java](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vZmllbGRkZWYvV2ViRmllbGREZWYuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-tubemq/pull/342/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=footer). Last update [39962bc...5958aad](https://codecov.io/gh/apache/incubator-tubemq/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #342: [TUBEMQ-437] Fix tubemq table source sink factory instance creating problem

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #342:
URL: https://github.com/apache/incubator-tubemq/pull/342


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org