You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Stefan9149 <gi...@git.apache.org> on 2015/12/22 01:03:17 UTC
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
GitHub user Stefan9149 opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/560
Add finish alert with blinking tab title
Users may have pending/running tasks and do not want to keep focusing on the web page.
This feature sends a simple notification in the form of blinking web page/tab title, so it can remind users about any updated paragraph with new status FINISHED/ERROR/ABORTED.
Blinking title will recover to original title after user re-focuses on the Zeppelin page.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Stefan9149/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #560
----
commit ca4d655abee965750b42be9e958a5b9eed16f84a
Author: Shao <ls...@amazon.com>
Date: 2015-12-21T23:55:20Z
Add finish alert with blinking tab title
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-167738426
I left a few comments here and there, I also think @felizbear is right about the camelCase.
Overall, the ``PageTitleNotification`` part could be done as a service.
For the feature itself, I found out that you never really see the message, depending on your tabs size, it could show just 5-6 characters, so it could be better to have an animated text (just like a prompter).
Didn't try on multiple web browsers yet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-167747867
I agree to what @corneadoug said; depending on your tabs size, it could show just 5-6 characters. So, you should think of animating text, ~~sound notification~~, or desktop notification.
Also, say I have more than one paragraph (say 20 of them), and then I click on run all notes; it start showing "You have a job finished!!!" as soon as first paragraph has completed execution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by Stefan9149 <gi...@git.apache.org>.
Github user Stefan9149 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-169476509
Thanks for all your comments.
I agree with you that blinking tab title is not an ideal way to send notification. I found this project [angular-web-notification](https://github.com/sagiegurari/angular-web-notification) which makes a wrapper of HTML5 desktop notification and supports for different browsers. I incorporated it into Zeppelin, it works like this:
How do you guys think?
For the "run all paragraphs" issue, indeed we need to find a way to make it as an exception and only send notification when all paragraphs are finished. However I didn't figure out how to keep track of this progress. I can disable notification with "runNote", but I have no idea where/when to re-enable it. And it seems that Zeppelin now supports multi-thread execution within one notebook, so tracking status of last paragraph doesn't work neither. Any suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-166501512
Great stuff! Page title is important way to communicate to user indeed.
@Stefan9149 There are couple of things you can do to make a contribution be accepted faster i.e for GUI changes it would help to have screenshot or animated gif attached to facilitate a feedback from reviewers.
Another thing that I was also thinking about is - may be we could use the page title as a notification to the user, but start with something less invasive than blinking, i.e as a first step just change the title to show status in text.
What do you guys think? \cc @corneadoug @felizbear @swkimme
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-192082411
where are we on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-166534387
Could you change the description to follow our PR Template?
(you can find it [here] (https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add finish alert with blinking ta...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-169551786
The browser support seems quite limited and the known issues not that great:
http://caniuse.com/#feat=notifications
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---