[GitHub] [airflow] CodingJonas commented on a change in pull request #8617: Extend docker swarm operator configuration

[GitBox <gi...@apache.org>]

CodingJonas commented on a change in pull request #8617:
URL: https://github.com/apache/airflow/pull/8617#discussion_r437686189



##########
File path: airflow/providers/docker/operators/docker_swarm.py
##########
@@ -93,20 +95,37 @@ class DockerSwarmOperator(DockerOperator):
         Supported only if the Docker engine is using json-file or journald logging drivers.
         The `tty` parameter should be set to use this with Python applications.
     :type enable_logging: bool
+    :param configs: List of ConfigReferences that will be exposed to the service
+    :type configs: list
+       Example: [{'source': my-conf, 'target': where/config/should/be/.env}]
+    :param secrets: List of SecretReference to be made available inside the containers
+    :type secrets: list
+    :param networks: List of network names or IDs to attach the service to
+    :type networks: list
     """
 
     @apply_defaults
     def __init__(
             self,
             image,
             enable_logging=True,
+            networks=None,
+            configs=None,
+            secrets=None,
             *args,
             **kwargs):
         super().__init__(image=image, *args, **kwargs)
 
         self.enable_logging = enable_logging
+        self.networks = networks
+        self.configs = configs
+        self.secrets = secrets
+        self.service_name = self._get_service_name()
         self.service = None
 
+    def _get_service_name(self):
+        return '%s__af_%s' % (self.task_id, get_random_string())

Review comment:
       Good point, I looked into it but didn't find any limitations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org