You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/08/29 19:59:32 UTC

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23360


Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................

IMPALA-13731: Deflake TestAsyncLoadData.test_async_load

This patch attempt to deflake TestAsyncLoadData::test_async_load by
moving the injection point CRS_DELAY_BEFORE_LOAD_DATA before query
transition to RUNNING state in async mode. This way, async code
path (enable_async_ddl_execution=true) with also delay its transition to
RUNNING state until 3 seconds pass. wait_start is also assigned the same
initial value as exec_start.

This patch does not change assertion / behavior in sync code
path (enable_async_ddl_execution=false).

Testing:
Loop and pass TestAsyncLoadData 50 times.

Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
---
M be/src/service/client-request-state.cc
M tests/metadata/test_load.py
2 files changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/23360/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12407/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:19:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:06:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py
File tests/metadata/test_load.py:

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py@207
PS1, Line 207:       handle = self.execute_query_async_using_client(client, load_stmt, new_vector)
> Here is my understanding on the timeline of the original test code in async
Thanks for reviewing this, Quanlong.
I agree just relaxing the test assertion works too.
Done.



-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 14:48:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py
File tests/metadata/test_load.py:

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py@207
PS1, Line 207:       wait_start = exec_start
> Agree that this can stabilize the test. But it's actually measuring the ent
Here is my understanding on the timeline of the original test code in async mode:

exec_start
execute_query
  ExecuteInternal -> ClientRequestState::ExecLoadDataRequest()
    change state to PENDING
    Thread::Create for the worker thread
    return to Client
exec_end
get exec_end_state    // the worker thread might not start yet (state is still PENDING)

wait_start
  wait_for_impala_state to be FINISHED
wait_end
wait_time = wait_end - wait_start

wait_time not strictly starts at the point when the thread starts. If it starts later due to get_impala_exec_state takes some time, wait_time < 3.

So the original test code could fail at exec_end_state is PENDING or wait_time < 3.



-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 13:15:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

Thank you all for your review!


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:19:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23360/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:

http://gerrit.cloudera.org:8080/#/c/23360/2/tests/metadata/test_load.py@227
PS2, Line 227:         assert (wait_time > 2)
My suggestion is checking exec_time < 3 or a smaller duration. I think what we care in async mode is exec_time instead of wait_time here.



-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 22:38:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py
File tests/metadata/test_load.py:

http://gerrit.cloudera.org:8080/#/c/23360/1/tests/metadata/test_load.py@207
PS1, Line 207:       wait_start = exec_start
Agree that this can stabilize the test. But it's actually measuring the entire duration of the statement. I think what we want the test to assert is that ExecuteStatement RPC returns quickly (for enable_async_load_data) regardless of the 3s delay. It's OK that after ExecuteStatement returns, the query state is PENDING or RUNNING. Clients like impala-shell will just wait for the FINISHED state.

So I think that changing the assertions on L227-228 to below might be better:

        assert exec_end_state == PENDING or exec_end_state == RUNNING
        assert exec_time < 3  # or use a smaller value

and keep the BE code unchanged so the debug action still mimic slowness in the DDL.



-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 13:06:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23360/2/tests/metadata/test_load.py
File tests/metadata/test_load.py:

http://gerrit.cloudera.org:8080/#/c/23360/2/tests/metadata/test_load.py@227
PS2, Line 227:         assert (wait_time > 2)
> My suggestion is checking exec_time < 3 or a smaller duration. I think what
Apologies, I mistook your comment.
I think this will be somewhat similar, but I'll make follow up change if this turn out to be an issue.



-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 23:19:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................

IMPALA-13731: Deflake TestAsyncLoadData.test_async_load

This patch attempt to deflake TestAsyncLoadData::test_async_load by
allowing exec_end_state == PENDING if enable_async_load_data. This is OK
because, if enable_async_load_data is true, async_exec_thread_ might be
slightly slower to start and transition the query to RUNNING. wait_time
is also relaxed to at least 2 seconds because wait_start not strictly
starts at the point when the async_exec_thread_ starts.

This patch does not change assertion / behavior in sync code
path (enable_async_ddl_execution=false).

Testing:
Loop and pass TestAsyncLoadData 50 times.

Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Reviewed-on: http://gerrit.cloudera.org:8080/23360
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_load.py
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Jason Fehr: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 23:36:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23360

to look at the new patch set (#2).

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................

IMPALA-13731: Deflake TestAsyncLoadData.test_async_load

This patch attempt to deflake TestAsyncLoadData::test_async_load by
allowing exec_end_state == PENDING if enable_async_load_data. This is OK
because, if enable_async_load_data is true, async_exec_thread_ might be
slightly slower to start and transition the query to RUNNING. wait_time
is also relaxed to at least 2 seconds because wait_start not strictly
starts at the point when the async_exec_thread_ starts.

This patch does not change assertion / behavior in sync code
path (enable_async_ddl_execution=false).

Testing:
Loop and pass TestAsyncLoadData 50 times.

Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
---
M tests/metadata/test_load.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/23360/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:01:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20327/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 15:15:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13731: Deflake TestAsyncLoadData.test async load

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23360 )

Change subject: IMPALA-13731: Deflake TestAsyncLoadData.test_async_load
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20318/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8776a432e60a1167ad54778e81046421df15cf37
Gerrit-Change-Number: 23360
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Aug 2025 20:26:19 +0000
Gerrit-HasComments: No