You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "pkolaczk (via GitHub)" <gi...@apache.org> on 2023/09/11 08:24:42 UTC

[GitHub] [cassandra] pkolaczk commented on a diff in pull request #2556: Cep 29 not operator

pkolaczk commented on code in PR #2556:
URL: https://github.com/apache/cassandra/pull/2556#discussion_r1321173637


##########
src/java/org/apache/cassandra/utils/btree/BTree.java:
##########
@@ -347,8 +347,8 @@ public static <Compare, Existing extends Compare, Insert extends Compare> Object
 
         if (isEmpty(toUpdate))
         {
-            if (isSimple(updateF))
-                return insert; // if update is empty and updateF is trivial, return our new input
+//            if (isSimple(updateF))
+//                return insert; // if update is empty and updateF is trivial, return our new input

Review Comment:
   Quite likely not. I just accidentally commeted it out during testing. Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org