You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/22 18:51:17 UTC

[GitHub] [calcite] laurentgo commented on a change in pull request #1210: CALCITE-3065, consider primitive type in method RexLiteral#getValueAs.

laurentgo commented on a change in pull request #1210: CALCITE-3065, consider primitive type in method RexLiteral#getValueAs.
URL: https://github.com/apache/calcite/pull/1210#discussion_r286597675
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexLiteral.java
 ##########
 @@ -970,7 +970,7 @@ public Comparable getValue4() {
       }
       break;
     case DECIMAL:
-      if (clazz == Long.class) {
+      if (clazz == Long.class || clazz == long.class) {
 
 Review comment:
   The best way to confirm this works is to add unit tests...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services