You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/08/03 18:31:48 UTC
[PR] fix(ci): validate frontend dependency tree [superset]
sadpandajoe opened a new pull request, #42720:
URL: https://github.com/apache/superset/pull/42720
### SUMMARY
Repairs the unowned `fs-extra` failure from [Dependabot run 30792144540](https://github.com/apache/superset/actions/runs/30792144540).
PR #42635 updated the generator workspace manifest and root lock entry to `fs-extra@11.4.0`, but left a stale nested `packages/generator-superset/node_modules/fs-extra@11.3.2` lock node. Dependabot's package-manager command therefore exited successfully without changing a file, and the updater raised `Dependabot::NpmAndYarn::FileUpdater::NoChangeError`.
This change:
- removes only the stale nested lock node, allowing the workspace to deduplicate to `fs-extra@11.4.0`;
- validates the complete package-lock dependency tree in frontend CI so stale workspace nodes are detected before the next Dependabot run.
PR #42653 addresses the separate deck.gl/luma.gl `EOVERRIDE` failures from the same Dependabot run; this PR intentionally does not duplicate that policy change.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable.
### TESTING INSTRUCTIONS
From `superset-frontend`:
```bash
npm ls fs-extra --all --package-lock-only
npm ls --all --package-lock-only --depth=0 --json > /dev/null
npm ci --ignore-scripts --dry-run
```
Workflow validation:
```bash
pre-commit run check-yaml --files .github/workflows/superset-frontend.yml
npx --yes --package=@action-validator/core@0.6.0 --package=@action-validator/cli@0.6.0 action-validator .github/workflows/superset-frontend.yml
```
`pre-commit run --all-files` was also executed. Installed backend/repository checks passed; frontend/docs hooks could not run without the workspace dependency installs and restricted registry access, Ruff reported pre-existing all-tree violations, and zizmor crashed in macOS system-configuration before parsing the workflow. Hook-generated unrelated formatting was discarded.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): validate frontend dependency tree [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42720:
URL: https://github.com/apache/superset/pull/42720#issuecomment-5170401649
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42720?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 65.43%. Comparing base ([`06628bb`](https://app.codecov.io/gh/apache/superset/commit/06628bbd68ed5c5822e2877eb545db6d20a8f811?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ce4d29c`](https://app.codecov.io/gh/apache/superset/commit/ce4d29c5464b008d9decd08d507830afaa3f68fa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 17 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42720 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 2810 2810
Lines 159528 159528
Branches 36410 36410
=======================================
Hits 104380 104380
Misses 53102 53102
Partials 2046 2046
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42720/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/42720/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.56% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42720?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): validate frontend dependency tree [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42720:
URL: https://github.com/apache/superset/pull/42720#issuecomment-5172124916
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): validate frontend dependency tree [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42720:
URL: https://github.com/apache/superset/pull/42720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): validate frontend dependency tree [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42720:
URL: https://github.com/apache/superset/pull/42720#issuecomment-5170265101
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): validate frontend dependency tree [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42720:
URL: https://github.com/apache/superset/pull/42720#issuecomment-5170282684
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | ce4d29c5464b008d9decd08d507830afaa3f68fa |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a70de96615f3500084e941b |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-42720--superset-docs-preview.netlify.app](https://deploy-preview-42720--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLDkAwEADQu8xaY1SN1g0co58RErSpLoi4u-7e4r2QcjxSgQmgAZft6ddqHwPfrd_EYa_CWSCR1M4JiZJQY19v4LTHZw51kx0xsCHqhqUfEFErNqpz8P0) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42720--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org