You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "chenkovsky (via GitHub)" <gi...@apache.org> on 2025/11/02 04:37:35 UTC
[PR] chore: simplify map const [datafusion]
chenkovsky opened a new pull request, #18440:
URL: https://github.com/apache/datafusion/pull/18440
## Which issue does this PR close?
## Rationale for this change
map const wont be simplified, the comment says "TODO: support the optimization for `Map` type after support impl hash for it", but it seems that hash is already supported for map.
## What changes are included in this PR?
remove the todo
## Are these changes tested?
UT
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: simplify map const [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #18440:
URL: https://github.com/apache/datafusion/pull/18440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: simplify map const [datafusion]
Posted by "chenkovsky (via GitHub)" <gi...@apache.org>.
chenkovsky commented on PR #18440:
URL: https://github.com/apache/datafusion/pull/18440#issuecomment-3478505343
I originally thought this was just a literal too. But it's `map(List([x]), List([100]))` on main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org