You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "freak82 (via GitHub)" <gi...@apache.org> on 2024/06/14 15:27:17 UTC

Re: [PR] Fix unused parameters in the tscpp source code [trafficserver]

freak82 commented on code in PR #11402:
URL: https://github.com/apache/trafficserver/pull/11402#discussion_r1639994187


##########
src/tscpp/api/utils_internal.cc:
##########
@@ -260,7 +260,7 @@ utils::internal::invokePluginForEvent(GlobalPlugin *plugin, TSHttpTxn ats_txn_ha
 }
 
 void
-utils::internal::invokePluginForEvent(GlobalPlugin *plugin, TSHttpAltInfo altinfo_handle, TSEvent event)
+utils::internal::invokePluginForEvent(GlobalPlugin *plugin, TSHttpAltInfo altinfo_handle, [[maybe_unused]] TSEvent event)

Review Comment:
   There is an assertion in this function which uses the `event` argument.
   That's why it's with `[[maybe_unused]]` instead of like the other ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org