You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2024/07/24 09:08:39 UTC
[PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
huangxiaopingRD opened a new pull request, #6563:
URL: https://github.com/apache/kyuubi/pull/6563
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #6562
## Describe Your Solution ๐ง
- Modify KyuubiSparkSQL.g4 syntax to support the zorder clause syntax to use brackets
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
zorder clause syntax can't use brackets
#### Behavior With This Pull Request :tada:
zorder clause syntax can use brackets
#### Related Unit Tests
---
# Checklist ๐
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1691047348
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
Just following the deltalake. https://docs.delta.io/latest/optimizations-oss.html#z-ordering-multi-dimensional-clustering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#issuecomment-2489814224
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1689685233
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
then I think we don't need to support that too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#issuecomment-2247512355
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6563?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 0.00%. Comparing base [(`05cb5b4`)](https://app.codecov.io/gh/apache/kyuubi/commit/05cb5b4112a1a445314482a668f9476f28262c48?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`88701bf`)](https://app.codecov.io/gh/apache/kyuubi/commit/88701bf7ed44493bcbc3aaca0ce34274d3207a3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #6563 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 677 677
Lines 41799 41799
Branches 5709 5709
======================================
Misses 41799 41799
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/6563?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1689632160
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
Does Spark SQL support `ORDER BY` with parentheses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1689689719
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
Got it, I just saw this todo in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1689674099
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
No, Spark does not support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1689710908
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
I think we can delete those code and comments, unless @ulysses-you and @cfmcgrady have other ideas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #6563:
URL: https://github.com/apache/kyuubi/pull/6563#discussion_r1690705005
##########
extensions/spark/kyuubi-extension-spark-3-3/src/test/scala/org/apache/spark/sql/ZorderSuiteBase.scala:
##########
@@ -746,14 +746,25 @@ trait ZorderSuiteBase extends KyuubiSparkSQLExtensionTest with ExpressionEvalHel
UnresolvedFunction("current_date", Seq.empty, false)),
UnresolvedRelation(TableIdentifier("p")))))))
- // TODO: add following case support
- intercept[ParseException] {
- parser.parsePlan("OPTIMIZE p zorder by (c1)")
Review Comment:
Seems added by @cfmcgrady , I'm fine to just remove the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6562] Support zorder clause syntax to use brackets [kyuubi]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6563: [KYUUBI #6562] Support zorder clause syntax to use brackets
URL: https://github.com/apache/kyuubi/pull/6563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org