You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Mark Yvanovich (JIRA)" <ad...@incubator.apache.org> on 2007/05/10 22:35:15 UTC
[jira] Created: (ADFFACES-489) DEBUG-OUTPUT HTML Pretty Printer
inserts unwanted whitespace after input element
DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
--------------------------------------------------------------------------------
Key: ADFFACES-489
URL: https://issues.apache.org/jira/browse/ADFFACES-489
Project: MyFaces ADF-Faces
Issue Type: Bug
Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
Environment: Must have DEBUG-OUTPUT set to true.
Reporter: Mark Yvanovich
Fix For: 1.0.1-incubating-plugins-SNAPSHOT
I have a component, selectOneRadio, that renders the following HTML for each radio button:
<span><input type='radio'/></span><label>My Label</label>
The HTML pretty printer is inserting space after the input element, causing extra space to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-489) DEBUG-OUTPUT HTML Pretty Printer
inserts unwanted whitespace after input element
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated ADFFACES-489:
------------------------------------
Status: Patch Available (was: Open)
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFaces-489-IndentingRW.diff
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-489) DEBUG-OUTPUT HTML Pretty Printer
inserts unwanted whitespace after input element
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated ADFFACES-489:
------------------------------------
Attachment: ADFFaces-489-IndentingRW.diff
adding a patch with the one-line fix.
Added "input" to this:
return ("img".equals(name) ||
"a".equals(name) ||
"br".equals(name) ||
"span".equals(name) ||
"div".equals(name) ||
"area".equals(name) ||
"u".equals(name) ||
"i".equals(name) ||
"input".equals(name) ||
"b".equals(name) ||
"em".equals(name) ||
"strong".equals(name) ||
"map".equals(name) ||
"label".equals(name) ||
"font".equals(name) ||
"table".equals(name) ||
"tbody".equals(name) ||
"tr".equals(name) ||
"nobr".equals(name) ||
"wbr".equals(name) ||
"script".equals(name));
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFaces-489-IndentingRW.diff
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-489) DEBUG-OUTPUT HTML Pretty Printer
inserts unwanted whitespace after input element
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494885 ]
Jeanne Waldman commented on ADFFACES-489:
-----------------------------------------
I think the fix is to "input" to the _isWhiteSpaceSensitive list in IndentingResponseWriter.
If I do this, then the newline after the input element is gone which is what we want.
> DEBUG-OUTPUT HTML Pretty Printer inserts unwanted whitespace after input element
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-489
> URL: https://issues.apache.org/jira/browse/ADFFACES-489
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.1-incubating-plugins-SNAPSHOT
> Environment: Must have DEBUG-OUTPUT set to true.
> Reporter: Mark Yvanovich
> Fix For: 1.0.1-incubating-plugins-SNAPSHOT
>
>
> I have a component, selectOneRadio, that renders the following HTML for each radio button:
> <span><input type='radio'/></span><label>My Label</label>
> The HTML pretty printer is inserting space after the input element, causing extra space to be rendered between the input and the label.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.