You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2025/08/16 02:25:07 UTC
[PR] [CELEBORN-2104] Fix NettyRpcEnv RpcSource thread leak [celeborn]
xy2953396112 opened a new pull request, #3418:
URL: https://github.com/apache/celeborn/pull/3418
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Fix NettyRpcEnv RpcSource thread leak
### Why are the changes needed?
NettyRpcEnv should clean rpcSource to prevent resource leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up sources of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3418: [CELEBORN-2104] Clean up sources of NettyRpcEnv, Master and Worker to avoid thread leaks
URL: https://github.com/apache/celeborn/pull/3418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Fix NettyRpcEnv RpcSource thread leak [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#issuecomment-3193386994
Could you check whether other `Source`s have same problem like `MasterSource` etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up the Source at the end of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#discussion_r2283791583
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -381,6 +385,14 @@ private[celeborn] class Master(
sendApplicationMetaExecutor.shutdownNow()
}
messagesHelper.close()
+
+ resourceConsumptionSource.destroy()
Review Comment:
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up the Source at the end of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#discussion_r2284138033
##########
service/src/main/scala/org/apache/celeborn/common/metrics/MetricsSystem.scala:
##########
@@ -100,6 +100,10 @@ class MetricsSystem(
}
}
+ def destroyAllSources(): Unit = {
Review Comment:
Remove this method. The sources could be destroy in `stop`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up the Source at the end of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#discussion_r2281839224
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -381,6 +385,14 @@ private[celeborn] class Master(
sendApplicationMetaExecutor.shutdownNow()
}
messagesHelper.close()
+
+ resourceConsumptionSource.destroy()
Review Comment:
Maybe better let `metricsSystem` to destroy all these sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up the Source at the end of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#discussion_r2295797477
##########
service/src/main/scala/org/apache/celeborn/common/metrics/MetricsSystem.scala:
##########
@@ -100,6 +100,10 @@ class MetricsSystem(
}
}
+ def destroyAllSources(): Unit = {
Review Comment:
PTAL, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Fix NettyRpcEnv RpcSource thread leak [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#issuecomment-3194903309
> Could you check whether other `Source`s have same problem like `MasterSource` etc?
has checked other `Source`, please review code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2104] Clean up sources of NettyRpcEnv, Master and Worker to avoid thread leaks [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3418:
URL: https://github.com/apache/celeborn/pull/3418#issuecomment-3236662760
Thanks for contribution. Merged to main(v0.7.0) and branch-0.6(v0.6.1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org