You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/04/18 15:26:48 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23723: feat: add enforce URI query params with a specific for MySQL
codecov[bot] commented on PR #23723:
URL: https://github.com/apache/superset/pull/23723#issuecomment-1513361502
## [Codecov](https://codecov.io/gh/apache/superset/pull/23723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23723](https://codecov.io/gh/apache/superset/pull/23723?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b75bdfe) into [master](https://codecov.io/gh/apache/superset/commit/c197bf9e6db85a76d8118a4ec11a83ca2f6aad6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c197bf9) will **decrease** coverage by `11.42%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head b75bdfe differs from pull request most recent head 35ac9b3. Consider uploading reports for the commit 35ac9b3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23723 +/- ##
===========================================
- Coverage 68.10% 56.68% -11.42%
===========================================
Files 1922 1922
Lines 74046 74049 +3
Branches 8104 8104
===========================================
- Hits 50426 41977 -8449
- Misses 21545 29997 +8452
Partials 2075 2075
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.09% <40.00%> (+<0.01%)` | :arrow_up: |
| python | `59.42% <100.00%> (-23.73%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.03% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/23723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `76.35% <100.00%> (-14.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/23723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `77.64% <100.00%> (-21.15%)` | :arrow_down: |
... and [300 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23723/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org