You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/21 08:37:55 UTC
[GitHub] [airflow] BobDu opened a new pull request, #27178: Add workeer log-groomer-sidecar enable option in helm chart
BobDu opened a new pull request, #27178:
URL: https://github.com/apache/airflow/pull/27178
Signed-off-by: BobDu <i...@bobdu.cc>
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
I see #16153 , add scheduler-log-groomer enable option, but not add a same option for worker.
I missing something? @jedcunningham
My airflow cluster use shared efs persistence logs.
But, if every worker start a sidecar container to scan log directory, is unnecessary, and it will use up efs throughout capacity.
We need a option to turn off it.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BobDu commented on pull request #27178: Add workeer log-groomer-sidecar enable option in helm chart
Posted by GitBox <gi...@apache.org>.
BobDu commented on PR #27178:
URL: https://github.com/apache/airflow/pull/27178#issuecomment-1339432806
@potiuk maybe we need add it in helm chart 1.8.0 milestone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27178: Add workeer log-groomer-sidecar enable option in helm chart
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27178:
URL: https://github.com/apache/airflow/pull/27178#issuecomment-1312708585
Merging. I think there is little controversy with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27178: Add workeer log-groomer-sidecar enable option in helm chart
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27178:
URL: https://github.com/apache/airflow/pull/27178#issuecomment-1339609516
No need. Helm Chart is released from main. If things are merged, they will be released in the next version - and we will mark them as the right version. Milestones are used for opened issues that we want to make sure are reviewed and possibly fixed (or pushed to the next release) before we release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27178: Add workeer log-groomer-sidecar enable option in helm chart
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27178:
URL: https://github.com/apache/airflow/pull/27178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BobDu commented on pull request #27178: Add workeer log-groomer-sidecar enable option in helm chart
Posted by GitBox <gi...@apache.org>.
BobDu commented on PR #27178:
URL: https://github.com/apache/airflow/pull/27178#issuecomment-1287069466
CI timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org