[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3659: Implement std::fmt::Write for StringBuilder (#3638)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3659:
URL: https://github.com/apache/arrow-rs/pull/3659#discussion_r1096668787


##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -235,6 +236,13 @@ impl<T: ByteArrayType, V: AsRef<T::Native>> Extend<Option<V>> for GenericByteBui
 ///  Array builder for [`GenericStringArray`][crate::GenericStringArray]
 pub type GenericStringBuilder<O> = GenericByteBuilder<GenericStringType<O>>;
 
+impl<O: OffsetSizeTrait> Write for GenericStringBuilder<O> {

Review Comment:
   Each individual call won't result in a new row, you need to explicitly append an empty string to delimit the record



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org