You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/12/21 15:40:18 UTC
Review Request 64779: NPE fix in closing idle connections [LENS-1497]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/
-----------------------------------------------------------
Review request for lens and Puneet Gupta.
Bugs: LENS-1497
https://issues.apache.org/jira/browse/LENS-1497
Repository: lens
Description
-------
NPE fix in closing idle connections
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
Diff: https://reviews.apache.org/r/64779/diff/1/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195810
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Jan. 19, 2018, 10:07 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2018, 10:07 a.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java a9fd233
>
>
> Diff: https://reviews.apache.org/r/64779/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/
-----------------------------------------------------------
(Updated Jan. 19, 2018, 10:07 a.m.)
Review request for lens and Puneet Gupta.
Bugs: LENS-1497
https://issues.apache.org/jira/browse/LENS-1497
Repository: lens
Description
-------
NPE fix in closing idle connections
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java a9fd233
Diff: https://reviews.apache.org/r/64779/diff/5/
Changes: https://reviews.apache.org/r/64779/diff/4-5/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195711
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 355 (patched)
<https://reviews.apache.org/r/64779/#comment274990>
Can we also log the session Handle
- Puneet Gupta
On Jan. 11, 2018, 3:07 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2018, 3:07 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java a9fd233
>
>
> Diff: https://reviews.apache.org/r/64779/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195712
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Jan. 11, 2018, 3:07 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2018, 3:07 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java a9fd233
>
>
> Diff: https://reviews.apache.org/r/64779/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/
-----------------------------------------------------------
(Updated Jan. 11, 2018, 3:07 p.m.)
Review request for lens and Puneet Gupta.
Bugs: LENS-1497
https://issues.apache.org/jira/browse/LENS-1497
Repository: lens
Description
-------
NPE fix in closing idle connections
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java a9fd233
Diff: https://reviews.apache.org/r/64779/diff/4/
Changes: https://reviews.apache.org/r/64779/diff/3-4/
Testing
-------
Thanks,
Rajitha R
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195018
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 231-235 (patched)
<https://reviews.apache.org/r/64779/#comment274119>
Is this required for restoreSession(...)flow only? If yes can we move it there ?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 236 (patched)
<https://reviews.apache.org/r/64779/#comment274118>
Why is this required ?
This method is called from openSession(..) and restoreSession(). The openSession call is already synchronized on sessionUser and the restoreSession happens in a single thread wand should not require synchronization.
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 350 (patched)
<https://reviews.apache.org/r/64779/#comment274120>
This should not be required now since we are adding missing users to this map on restoreSession.
- Puneet Gupta
On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 3:40 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
>
>
> Diff: https://reviews.apache.org/r/64779/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Rajitha R <ra...@gmail.com>.
> On Dec. 27, 2017, 11:51 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> > Lines 234 (patched)
> > <https://reviews.apache.org/r/64779/diff/2/?file=1926175#file1926175line234>
> >
> > should we return or add the missing user to SESSION_USER_INSTANCE_MAP ?
The user is added to this map in the same method before this call..so this can be called a redundant check
> On Dec. 27, 2017, 11:51 a.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> > Line 342 (original), 349 (patched)
> > <https://reviews.apache.org/r/64779/diff/2/?file=1926175#file1926175line349>
> >
> > Is this inconsistnecy coming due to a restart ? Can we handle this on restart itself in that case when session service boots up
When the system boots up, this map is correctly being updated. Confirming that from the code.
This issue seems to occur when there are active sessions(session map non empty) while sessions per user map being empty. This could have happened when multiple threads are trying to update the sessions per user map which doesn't have any synchronization. I have handled the same in the updatesessioncount method above.
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review194536
-----------------------------------------------------------
On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 3:40 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
>
>
> Diff: https://reviews.apache.org/r/64779/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 64779: NPE fix in closing idle connections
[LENS-1497]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review194536
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 234 (patched)
<https://reviews.apache.org/r/64779/#comment273359>
should we return or add the missing user to SESSION_USER_INSTANCE_MAP ?
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 342 (original), 349 (patched)
<https://reviews.apache.org/r/64779/#comment273360>
Is this inconsistnecy coming due to a restart ? Can we handle this on restart itself in that case when session service boots up
- Puneet Gupta
On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2017, 3:40 p.m.)
>
>
> Review request for lens and Puneet Gupta.
>
>
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE fix in closing idle connections
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434
>
>
> Diff: https://reviews.apache.org/r/64779/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>