You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/25 18:31:15 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4616: Add logs to api removeVpnUser
GutoVeronezi opened a new pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616
### Description
We verified that sometimes the command `removeVpnUser` fails, but we can't find the reason because there is no clear log message.
This PR intends to improve logging by adding the stack trace in case of fail of `removeVpnUser` command.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functioanlity)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It has been tested locally on a test lab, calling the api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r600815748
##########
File path: server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -419,7 +419,9 @@ public VpnUser doInTransaction(TransactionStatus status) {
public boolean removeVpnUser(long vpnOwnerId, String username, Account caller) {
final VpnUserVO user = _vpnUsersDao.findByAccountAndUsername(vpnOwnerId, username);
if (user == null) {
- throw new InvalidParameterValueException("Could not find vpn user " + username);
+ String errorMessage = String.format("Could not find VPN user=[%s]. VPN owner id=[%s]", username, vpnOwnerId);
+ s_logger.debug(errorMessage);
Review comment:
```suggestion
if(s_logger.isDebugEnabled()) {
String errorMessage = String.format("Could not find VPN user=[%s]. VPN owner id=[%s]", username, vpnOwnerId);
s_logger.debug(errorMessage);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936
I am more interested in the reason and the fix. do you have clue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r600887603
##########
File path: server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -419,7 +419,9 @@ public VpnUser doInTransaction(TransactionStatus status) {
public boolean removeVpnUser(long vpnOwnerId, String username, Account caller) {
final VpnUserVO user = _vpnUsersDao.findByAccountAndUsername(vpnOwnerId, username);
if (user == null) {
- throw new InvalidParameterValueException("Could not find vpn user " + username);
+ String errorMessage = String.format("Could not find VPN user=[%s]. VPN owner id=[%s]", username, vpnOwnerId);
+ s_logger.debug(errorMessage);
Review comment:
Or we could update `log4j` to version 2. :grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-886709923
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-886709623
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-886689821
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-886707851
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-867596929
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-868036660
<b>Trillian test result (tid-1091)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37706 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4616-t1091-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-869830665
@DaanHoogland @GabrielBrascher @weizhouapache @sureshanaparti @rhtyd is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-768157432
hope you can build locally because before this is in a release we are all a few months older ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767385812
I agree with @weizhouapache , @GutoVeronezi . Did you implement this locally and did you find a root cause?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-847042343
@DaanHoogland @GabrielBrascher @weizhouapache until now we did not reproduce the mentioned error; However, improve logging may help others to better troubleshoot this if it ever happens. Any update about this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-886689047
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936
I am more interested the reason and the fix. do you have clue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r601680079
##########
File path: server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
##########
@@ -419,7 +419,9 @@ public VpnUser doInTransaction(TransactionStatus status) {
public boolean removeVpnUser(long vpnOwnerId, String username, Account caller) {
final VpnUserVO user = _vpnUsersDao.findByAccountAndUsername(vpnOwnerId, username);
if (user == null) {
- throw new InvalidParameterValueException("Could not find vpn user " + username);
+ String errorMessage = String.format("Could not find VPN user=[%s]. VPN owner id=[%s]", username, vpnOwnerId);
+ s_logger.debug(errorMessage);
Review comment:
yes, please. to 3 by now. but as we don't use facadeproxy modules for 3rd party libraries that's not a trivial job and needs heavy sponsoring by volunteers :togueincheek: :a.k.a.: :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#discussion_r600815199
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vpn/RemoveVpnUserCmd.java
##########
@@ -110,19 +111,31 @@ public String getEventType() {
@Override
public void execute() {
Account owner = _accountService.getAccount(getEntityOwnerId());
- boolean result = _ravService.removeVpnUser(owner.getId(), userName, CallContext.current().getCallingAccount());
+ long ownerId = owner.getId();
+ boolean result = _ravService.removeVpnUser(ownerId, userName, CallContext.current().getCallingAccount());
if (!result) {
- throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to remove vpn user");
+ String errorMessage = String.format("Failed to remove VPN user=[%s]. VPN owner id=[%s].", userName, ownerId);
+ s_logger.error(errorMessage);
+ throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, errorMessage);
}
+ boolean appliedVpnUsers = false;
+
try {
- if (!_ravService.applyVpnUsers(owner.getId(), userName)) {
- throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to apply vpn user removal");
- }
- }catch (Exception ex) {
- throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to remove vpn user due to resource unavailable");
+ appliedVpnUsers = _ravService.applyVpnUsers(ownerId, userName);
+ } catch (ResourceUnavailableException ex) {
+ String errorMessage = String.format("Failed to refresh VPN user=[%s] due to resource unavailable. VPN owner id=[%s].", userName, ownerId);
+ s_logger.error(errorMessage, ex);
+ throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, errorMessage, ex);
+ }
+
+ if (!appliedVpnUsers) {
+ String errorMessage = String.format("Failed to refresh VPN user=[%s]. VPN owner id=[%s].", userName, ownerId);
+ s_logger.debug(errorMessage);
Review comment:
```suggestion
if(s_logger.isDebugEnabled()) {
String errorMessage = String.format("Failed to refresh VPN user=[%s]. VPN owner id=[%s].", userName, ownerId);
s_logger.debug(errorMessage);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-887098764
<b>Trillian test result (tid-1376)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33912 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4616-t1376-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-863776343
<b>Trillian test result (tid-975)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 69247 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4616-t975-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 10 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 3.97 | test_accounts.py
test_forceDeleteDomain | `Failure` | 3.99 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.00 | test_accounts.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 495.10 | test_internal_lb.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 344.54 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 331.46 | test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 511.20 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 511.21 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 454.05 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 499.48 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rafaelweingartner commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
rafaelweingartner commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-806034975
Guys, this is an interesting improvement in logging. Sadly, this has not been reproduced anymore. That is why we proposed an improvement for the logging here, to help others to better troubleshoot this if it ever happens with other people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936
I am more interested the reason and the fix. do you have clue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-806055197
Is this a known issue? Can anyone else attest/reproduce it?
I am not a VPN user, the last time I have played with it was a long time ago. What I can say is that I agree with you all.
@DaanHoogland @weizhouapache I totally agree with the preference for looking into a fix.
However, on the other hand, it seems to be a corner case and the contributor had no conditions to catch a propper log neither to reproduce it. Improving logs seems logical to me as well as a very necessary first step.
It can be really tricky to debug/reproduce issues and sometimes we get into a limbo where we cannot properly debug nor monitor issues. Is this the case @rafaelweingartner @GutoVeronezi?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-883360049
@DaanHoogland @GabrielBrascher @weizhouapache @sureshanaparti @rhtyd is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-867596203
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767727436
I have tested locally and couldn't found the root cause yet. Anyway, there is a lack of logs in this process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-855905170
@DaanHoogland @GabrielBrascher @weizhouapache @sureshanaparti is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936
I am more interested in the reason and the fix. do you have clue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4616: Add logs to api removeVpnUser
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4616:
URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-869830665
@DaanHoogland @GabrielBrascher @weizhouapache @sureshanaparti @rhtyd is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org