You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Pil0tXia (via GitHub)" <gi...@apache.org> on 2024/01/09 10:21:01 UTC
[I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Pil0tXia opened a new issue, #4733:
URL: https://github.com/apache/eventmesh/issues/4733
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request

`e.printStackTrace()` should be substituted with `log.error()` in these classes:
- org.apache.eventmesh.runtime.client.impl.PubClientImpl
- org.apache.eventmesh.openconnect.SourceWorker
- org.apache.eventmesh.common.ThreadWrapperTest
### Describe the solution you'd like
Take `org.apache.eventmesh.runtime.client.impl.PubClientImpl` as an example:

### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1893893199
@Pil0tXia This issue has finished?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "MovieTone (via GitHub)" <gi...@apache.org>.
MovieTone commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1882933246
Hi @Pil0tXia, I can fix this enhancement issue as well, would be happy to be assigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1890955418
@archit-8
> share path of a files where changes are going to happen.
They are listed in the body of the issue:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "archit-8 (via GitHub)" <gi...@apache.org>.
archit-8 commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1890951501
thanks, hey can you share path of a files where changes are going to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1882968392
@MovieTone How about temporarily leaving this issue to someone else who is interested in contributing to open source?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1884190334
@ppkarwasz Hah, I remember that. There are only three remaining usages of printStackTrace(), which can be resolved in a good first issue.😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1893915181
@mxsm Not yet. The assignee haven't submit a PR yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1890890343
@archit-8 Welcome to Apache EventMesh community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "archit-8 (via GitHub)" <gi...@apache.org>.
archit-8 commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1890983569
1.org.apache.eventmesh.runtime.client.impl.PubClientImpl
not able to relocate this class in a project
2.org.apache.eventmesh.openconnect.SourceWorker
changes are made successfully and merged
3.org.apache.eventmesh.common.ThreadWrapperTest
no changes
thanks for help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia closed issue #4733: [Enhancement] Substitute `e.printStackTrace()` with `log.error()`
URL: https://github.com/apache/eventmesh/issues/4733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "MovieTone (via GitHub)" <gi...@apache.org>.
MovieTone commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1883050453
@Pil0tXia Yes, sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "archit-8 (via GitHub)" <gi...@apache.org>.
archit-8 commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1890882594
Hi @Pil0tXia, can you assign me this enhancement issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Substitute `e.printStackTrace()` with `log.error()` (eventmesh)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #4733:
URL: https://github.com/apache/eventmesh/issues/4733#issuecomment-1883694532
@Pil0tXia,
There is an OpenRewrite recipe for this: https://docs.openrewrite.org/recipes/java/logging/printstacktracetologerror
You can also run it regularly to convert new call sites of `Throwable#printStackTrace()` (some IDEs, such as Eclipse add it as default `catch` content).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org