You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Murad M (JIRA)" <ji...@apache.org> on 2019/02/14 00:51:00 UTC

[jira] [Commented] (KAFKA-7930) StreamsResetter makes "changelog" topic naming assumptions

    [ https://issues.apache.org/jira/browse/KAFKA-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767751#comment-16767751 ] 

Murad M commented on KAFKA-7930:
--------------------------------

Patch provided: https://github.com/muradm/kafka/pull/1

> StreamsResetter makes "changelog" topic naming assumptions
> ----------------------------------------------------------
>
>                 Key: KAFKA-7930
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7930
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, tools
>    Affects Versions: 2.1.0
>            Reporter: Murad M
>            Priority: Major
>              Labels: features, usability
>
> StreamsResetter deletes the topics considered internal. Currently it just checks the naming as per [code|https://github.com/apache/kafka/blob/1aae604861068bb7337d4972c9dcc0c0a99c374d/core/src/main/scala/kafka/tools/StreamsResetter.java#L660]. If assumption is wrong (either topic prefix or suffix), tool becomes useless if aware even dangerous if not. Probably better either:
>  * naming assumption should be optional and supply internal topics with argument (--internal-topics)
>  * deletion could be optional (--no-delete-internal)
>  * ignore topics which are included in list of --input-topics
> Faced this, when was trying to reset applications with GlobalKTable topics named as *-changelog. Such topics sometimes are not desirable for deletion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)