You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Xiaoxiao Hou (JIRA)" <ji...@apache.org> on 2012/06/15 00:59:42 UTC
[jira] [Created] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Xiaoxiao Hou created HIVE-3140:
----------------------------------
Summary: Comment indenting is broken for "describe" in CLI
Key: HIVE-3140
URL: https://issues.apache.org/jira/browse/HIVE-3140
Project: Hive
Issue Type: Bug
Components: CLI
Reporter: Xiaoxiao Hou
Fix For: 0.10.0
Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
birthdayParam string 1 = comment1
2 = comment2
3 = comment3
But it supposed to display as:
birthdayParam string 1 = comment1
2 = comment2
3 = comment3
Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain reassigned HIVE-3140:
--------------------------------
Assignee: Zhenxiao Luo
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Xiaoxiao Hou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiaoxiao Hou updated HIVE-3140:
-------------------------------
Labels: patch (was: )
Status: Patch Available (was: Open)
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Labels: patch
> Fix For: 0.10.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510350#comment-13510350 ]
Zhenxiao Luo commented on HIVE-3140:
------------------------------------
Review Request submitted at:
https://phabricator.fb.com/D648742
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511105#comment-13511105 ]
Namit Jain commented on HIVE-3140:
----------------------------------
I will take a look
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511101#comment-13511101 ]
Zhenxiao Luo commented on HIVE-3140:
------------------------------------
[~namit], A review request is submitted at:
https://reviews.facebook.net/D7173
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-3140:
-------------------------------
Attachment: HIVE-3140.1.patch.txt
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo reassigned HIVE-3140:
----------------------------------
Assignee: Zhenxiao Luo
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3140:
-----------------------------
Status: Open (was: Patch Available)
minor comments on phabricator
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511100#comment-13511100 ]
Namit Jain commented on HIVE-3140:
----------------------------------
[~zhenxiao], can you submit a new patch at reviews.facebook.net (I mean, not a internal fb review, but a external review).
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Zhenxiao Luo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenxiao Luo updated HIVE-3140:
-------------------------------
Status: Patch Available (was: Open)
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Assignee: Zhenxiao Luo
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3140:
-----------------------------
Assignee: (was: Zhenxiao Luo)
Status: Open (was: Patch Available)
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: HIVE-3140.1.patch.txt
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3140) Comment indenting is broken for
"describe" in CLI
Posted by "Xiaoxiao Hou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295368#comment-13295368 ]
Xiaoxiao Hou commented on HIVE-3140:
------------------------------------
Please refer to diff:
https://reviews.facebook.net/D3663
> Comment indenting is broken for "describe" in CLI
> -------------------------------------------------
>
> Key: HIVE-3140
> URL: https://issues.apache.org/jira/browse/HIVE-3140
> Project: Hive
> Issue Type: Bug
> Components: CLI
> Reporter: Xiaoxiao Hou
> Fix For: 0.10.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Just go into the CLI and type "describe [TABLE_NAME]". If a comment has multiple lines, it is completely unreadable due to poor comment indenting. For example:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> But it supposed to display as:
> birthdayParam string 1 = comment1
> 2 = comment2
> 3 = comment3
> Comments should be indented the same amount on each line, i.e., if the comment starts at row k for the first line of the comment, it should be indented by k on line 2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira