You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Lilianne E. Blaze" <li...@tlen.pl> on 2004/08/11 08:46:25 UTC

[Patch] ExtendedAccessLogValve - broken x-H(requestedSessionIdValid)

Hello,
This is the first time I submit a patch, so I hope I do everything right.

ExtendedAccessLogValve is broken, code x-H(requestedSessionIdValid) returns the same result as 

x-H(requestedSessionId) due to a typo.

Greetings, Lilianne E. Blaze

Index: ExtendedAccessLogValve.java
===================================================================
RCS file: 

/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java,v
retrieving revision 1.9
diff -u -r1.9 ExtendedAccessLogValve.java
--- ExtendedAccessLogValve.java	23 Jun 2004 08:24:57 -0000	1.9
+++ ExtendedAccessLogValve.java	11 Aug 2004 03:13:42 -0000
@@ -1324,7 +1324,7 @@
             } else if ("requestedSessionIdFromCookie".equals(fieldInfo.value)){
                 fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONIDFROMCOOKIE;
             } else if ("requestedSessionIdValid".equals(fieldInfo.value)){
-                fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONID;
+                fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONIDVALID;
             } else if ("contentLength".equals(fieldInfo.value)){
                 fieldInfo.location = FieldInfo.X_LOC_CONTENTLENGTH;
             } else if ("characterEncoding".equals(fieldInfo.value)){

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Re: [Patch] ExtendedAccessLogValve - broken x-H(requestedSessionIdValid)

Posted by Tim Funk <fu...@joedog.org>.
Its now bugzilla 30587.


-Tim

Lilianne E. Blaze wrote:
> Hello,
> 
> This is the first time I submit a patch, so I hope I do everything right.
> 
> 
> 
> ExtendedAccessLogValve is broken, code x-H(requestedSessionIdValid) returns the same result as 
> 
> 
> 
> x-H(requestedSessionId) due to a typo.
> 
> 
> 
> Greetings, Lilianne E. Blaze
> 
> 
> 
> Index: ExtendedAccessLogValve.java
> 
> ===================================================================
> 
> RCS file: 
> 
> 
> 
> /home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ExtendedAccessLogValve.java,v
> 
> retrieving revision 1.9
> 
> diff -u -r1.9 ExtendedAccessLogValve.java
> 
> --- ExtendedAccessLogValve.java	23 Jun 2004 08:24:57 -0000	1.9
> 
> +++ ExtendedAccessLogValve.java	11 Aug 2004 03:13:42 -0000
> 
> @@ -1324,7 +1324,7 @@
> 
>              } else if ("requestedSessionIdFromCookie".equals(fieldInfo.value)){
> 
>                  fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONIDFROMCOOKIE;
> 
>              } else if ("requestedSessionIdValid".equals(fieldInfo.value)){
> 
> -                fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONID;
> 
> +                fieldInfo.location = FieldInfo.X_LOC_REQUESTEDSESSIONIDVALID;
> 
>              } else if ("contentLength".equals(fieldInfo.value)){
> 
>                  fieldInfo.location = FieldInfo.X_LOC_CONTENTLENGTH;
> 
>              } else if ("characterEncoding".equals(fieldInfo.value)){
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org