You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Shwetha G S (JIRA)" <ji...@apache.org> on 2014/01/08 10:01:00 UTC

[jira] [Updated] (OOZIE-1664) PollablePriorityDelayQueue.poll() returns elements with +ve delay

     [ https://issues.apache.org/jira/browse/OOZIE-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shwetha G S updated OOZIE-1664:
-------------------------------

    Description: 
In CallableQueueService:
{noformat}
            queue = new PollablePriorityDelayQueue<CallableWrapper>(3, 1000 * 30, TimeUnit.MILLISECONDS, queueSize) {

                @Override
                protected boolean eligibleToPoll(QueueElement<?> element) {
                    if (element != null) {
                        CallableWrapper wrapper = (CallableWrapper) element;
                        if (element.getElement() != null) {
                            return callableReachMaxConcurrency(wrapper.getElement());
                        }
                    }
                    return false;
                }

            };
{noformat}

elegibleToPoll() doesn't check if delay is -ve and in PollablePriorityQueue.poll() iterates over all elements and return any element whose concurrency is not maxed
{noformat}
                    Iterator<QueueElement<E>> iter = queues[i - 1].iterator();
                    while(e == null && iter.hasNext()) {
                        e = iter.next();
                        if (eligibleToPoll(e)) {
                            queues[i - 1].remove(e);
                        }
                        else {
                            debug("poll(): the iterator element [{0}], from P[{1}] is not eligible to poll", e.getElement().toString(), i);
                            e = null;
                        }
                    }
{noformat}

  was:
In CallableQueueService:
{noformat}
            queue = new PollablePriorityDelayQueue<CallableWrapper>(3, 1000 * 30, TimeUnit.MILLISECONDS, queueSize) {

                @Override
                protected boolean eligibleToPoll(QueueElement<?> element) {
                    if (element != null) {
                        CallableWrapper wrapper = (CallableWrapper) element;
                        if (element.getElement() != null) {
                            return callableReachMaxConcurrency(wrapper.getElement());
                        }
                    }
                    return false;
                }

            };
{noformat}

elegibleToPoll doesn't check if delay is -ve and in PollablePriorityQueue.poll(), it iterates over all elements and return any element whose concurrency is not maxed
{noformat}
                    Iterator<QueueElement<E>> iter = queues[i - 1].iterator();
                    while(e == null && iter.hasNext()) {
                        e = iter.next();
                        if (eligibleToPoll(e)) {
                            queues[i - 1].remove(e);
                        }
                        else {
                            debug("poll(): the iterator element [{0}], from P[{1}] is not eligible to poll", e.getElement().toString(), i);
                            e = null;
                        }
                    }
{noformat}


> PollablePriorityDelayQueue.poll() returns elements with +ve delay
> -----------------------------------------------------------------
>
>                 Key: OOZIE-1664
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1664
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>
> In CallableQueueService:
> {noformat}
>             queue = new PollablePriorityDelayQueue<CallableWrapper>(3, 1000 * 30, TimeUnit.MILLISECONDS, queueSize) {
>                 @Override
>                 protected boolean eligibleToPoll(QueueElement<?> element) {
>                     if (element != null) {
>                         CallableWrapper wrapper = (CallableWrapper) element;
>                         if (element.getElement() != null) {
>                             return callableReachMaxConcurrency(wrapper.getElement());
>                         }
>                     }
>                     return false;
>                 }
>             };
> {noformat}
> elegibleToPoll() doesn't check if delay is -ve and in PollablePriorityQueue.poll() iterates over all elements and return any element whose concurrency is not maxed
> {noformat}
>                     Iterator<QueueElement<E>> iter = queues[i - 1].iterator();
>                     while(e == null && iter.hasNext()) {
>                         e = iter.next();
>                         if (eligibleToPoll(e)) {
>                             queues[i - 1].remove(e);
>                         }
>                         else {
>                             debug("poll(): the iterator element [{0}], from P[{1}] is not eligible to poll", e.getElement().toString(), i);
>                             e = null;
>                         }
>                     }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)