[GitHub] [spark] zhengruifeng commented on a diff in pull request #42847: [SPARK-45128][SQL] Support `CalendarIntervalType` in Arrow

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #42847:
URL: https://github.com/apache/spark/pull/42847#discussion_r1322582952


##########
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java:
##########
@@ -289,7 +289,7 @@ public final ColumnarRow getStruct(int rowId) {
    * is a long type vector, containing all the microsecond values of all the interval values in this
    * vector.
    */
-  public final CalendarInterval getInterval(int rowId) {
+  public CalendarInterval getInterval(int rowId) {

Review Comment:
   if this approach is fine, I will need to update the comments above:
   
   >  To support interval type, implementations must implement {@link #getChild(int)} and define 3
   >    * child vectors: the first child vector is an int type vector, containing all the month values of
   >    * all the interval values in this vector. The second child vector is an int type vector,
   >    * containing all the day values of all the interval values in this vector. The third child vector
   >    * is a long type vector, containing all the microsecond values of all the interval values in this
   >    * vector.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org