You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/02/18 02:00:04 UTC
[PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
dongjoon-hyun opened a new pull request, #54355:
URL: https://github.com/apache/spark/pull/54355
### What changes were proposed in this pull request?
This PR aims to improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting`
### Why are the changes needed?
Some DBMS images enter `Running` status even they are not ready to receive the connnection. This new API will help us handle those images.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54355:
URL: https://github.com/apache/spark/pull/54355#issuecomment-3918745093
Could you review this PR too, @sarutak ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54355:
URL: https://github.com/apache/spark/pull/54355#issuecomment-3918117810
Could you review this PR, @peter-toth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54355:
URL: https://github.com/apache/spark/pull/54355#discussion_r2819960087
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala:
##########
@@ -255,6 +256,11 @@ abstract class DockerJDBCIntegrationSuite
*/
def dataPreparation(connection: Connection): Unit
+ /**
+ * Sleep for a while before testing.
+ */
+ def sleepBeforeTesting(): Unit = {}
Review Comment:
By default, this has the default no-op function body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54355: [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting`
URL: https://github.com/apache/spark/pull/54355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55578][SQL][TESTS] Improve `DockerJDBCIntegrationSuite` to support `sleepBeforeTesting` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54355:
URL: https://github.com/apache/spark/pull/54355#issuecomment-3918813387
Thank you so much, @sarutak ! Merged to master for Apache Spark 4.2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org