You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/28 07:06:50 UTC
[GitHub] [pinot] snleee commented on a diff in pull request #9864: [bugfix] fix mergeRollupTask metrics
snleee commented on code in PR #9864:
URL: https://github.com/apache/pinot/pull/9864#discussion_r1033185253
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -660,7 +662,7 @@ private void resetDelayMetrics(String tableNameWithType) {
* Reset the delay metrics for the given table name and merge level.
*
* @param tableNameWithType table name with type
- * @param mergeLevel merge level
+ * @param mergeLevel merge levelM
Review Comment:
typo?
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -617,19 +619,19 @@ private void createOrUpdateDelayMetrics(String tableNameWithType, String mergeLe
// Update gauge value that indicates the delay in terms of the number of time buckets.
Map<String, Long> watermarkForTable =
_mergeRollupWatermarks.computeIfAbsent(tableNameWithType, k -> new ConcurrentHashMap<>());
- _tableMaxValidBucketEndTimeMs.put(tableNameWithType, maxValidBucketEndTimeMs);
watermarkForTable.compute(mergeLevel, (k, v) -> {
if (v == null) {
LOGGER.info(
"Creating the gauge metric for tracking the merge/roll-up task delay for table: {} and mergeLevel: {}."
+ "(watermarkMs={}, bufferTimeMs={}, bucketTimeMs={}, taskDelayInNumTimeBuckets={})", tableNameWithType,
- mergeLevel, watermarkMs, bucketTimeMs, bucketTimeMs,
+ mergeLevel, watermarkMs, bufferTimeMs, bucketTimeMs,
Review Comment:
good catch 👍
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -459,7 +462,7 @@ private long getValidBucketEndTimeMsForSegment(SegmentZKMetadata segmentZKMetada
// the rounded segment end time of [10/1 00:00, 10/1 23:59] is 10/2 00:00. The rounded segment end time of
// [10/1 00:00, 10/2 00:00] is 10/3 00:00
long validBucketEndTimeMs = (segmentZKMetadata.getEndTimeMs() / bucketMs + 1) * bucketMs;
- validBucketEndTimeMs = Math.min(validBucketEndTimeMs, (currentTimeMs - bucketMs) / bucketMs * bucketMs);
+ validBucketEndTimeMs = Math.min(validBucketEndTimeMs, (currentTimeMs - bufferMs) / bucketMs * bucketMs);
Review Comment:
good catch 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org