You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/12/17 14:31:09 UTC
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1466
[FLINK-3180] [runtime] Log direct memory usage in MemoryLogger
The off-heap stats reported by the memory logger didn't include direct memory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3180-memlog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1466
----
commit ce6688dbe0a70c161e8995a1a279f54f15380b4e
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-12-17T13:28:15Z
[FLINK-3180] [runtime] Log direct memory usage in MemoryLogger
The off-heap stats reported by the memory logger didn't include
direct memory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1466#issuecomment-165726928
@uce Sure. We can do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1466#issuecomment-165486967
Thanks for the pull request. Could we also include the direct memory in the `getMemoryUsageStatsAsString()` which outputs memory information on task manager startups?
Looks good to merge otherwise!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1466#issuecomment-165524534
I've added some related changes to this PR to display the direct memory usage in the web frontend as well. The current structure didn't make a lot of sense to me:
## Current
## This PR
It's not that beautiful, but I think the ordering makes more sense now. I've also fixed a bug with the reporting of the PS-Scavenge GC times.
(PS: Sorry for overloading this PR.)
@mxm Is it OK if we address your comment in a follow up? I'm not sure how the respective bean is initialized and how expensive it is. In contrast to the other beans, this is not just a getter which initializes the bean on first access.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1466#issuecomment-166330037
LGTM, will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3180] [runtime] Log direct memory usage...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1466#issuecomment-165741781
Nice addition.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---