[GitHub] [airflow] vagetablechicken commented on a diff in pull request #25119: Add openmldb provider

[GitBox <gi...@apache.org>]

vagetablechicken commented on code in PR #25119:
URL: https://github.com/apache/airflow/pull/25119#discussion_r923215823


##########
airflow/providers/openmldb/provider.yaml:
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+package-name: apache-airflow-providers-openmldb
+name: OpenMLDB
+description: |
+    `OpenMLDB <https://openmldb.ai/>`__
+
+versions:
+  - 1.0.0
+
+dependencies:
+  - apache-airflow>=2.2.0
+  - apache-airflow-providers-http

Review Comment:
   > The project has Python SDK https://openmldb.ai/docs/en/v0.4/quickstart/python_sdk.html https://pypi.org/project/openmldb/ https://github.com/4paradigm/OpenMLDB
   > 
   > We prefer use official Python SDK when existed unless there is a good reason to avoid it?
   
   The OpenMLDB python SDK is using the shared lib created by swig. It'll meet many import error when using OpenMLDB python sdk with some complicate systems, e.g. airflow, xgboost. So we prefer the lightweight way(restful api) to connect OpenMLDB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org