You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2017/11/17 18:44:57 UTC
[geode] branch feature/GEODE-3781 updated (7fd92d5 -> f40cef0)
This is an automated email from the ASF dual-hosted git repository.
klund pushed a change to branch feature/GEODE-3781
in repository https://gitbox.apache.org/repos/asf/geode.git.
from 7fd92d5 Refactor long methods and add types
new b85f756 Move geode-connectors further up
new f40cef0 Fix spotless format
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/geode/connectors/jdbc/internal/ConnectionManager.java | 9 +++++----
.../org/apache/geode/connectors/jdbc/internal/SqlHandler.java | 3 ++-
.../geode/connectors/jdbc/internal/xml/ElementTypeTest.java | 3 ++-
settings.gradle | 2 +-
4 files changed, 10 insertions(+), 7 deletions(-)
--
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].
[geode] 02/02: Fix spotless format
Posted by kl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
klund pushed a commit to branch feature/GEODE-3781
in repository https://gitbox.apache.org/repos/asf/geode.git
commit f40cef0f6a4ecdfac6bface6cb3dd3c0b8aae91f
Author: Kirk Lund <kl...@apache.org>
AuthorDate: Fri Nov 17 10:44:35 2017 -0800
Fix spotless format
---
.../apache/geode/connectors/jdbc/internal/ConnectionManager.java | 9 +++++----
.../org/apache/geode/connectors/jdbc/internal/SqlHandler.java | 3 ++-
.../geode/connectors/jdbc/internal/xml/ElementTypeTest.java | 3 ++-
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java
index 462c51c..d382112 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/ConnectionManager.java
@@ -58,7 +58,7 @@ class ConnectionManager {
}
<K> List<ColumnValue> getColumnToValueList(ConnectionConfiguration config,
- RegionMapping regionMapping, K key, PdxInstance value, Operation operation) {
+ RegionMapping regionMapping, K key, PdxInstance value, Operation operation) {
String keyColumnName = getKeyColumnName(config, regionMapping.getTableName());
ColumnValue keyColumnValue = new ColumnValue(true, keyColumnName, key);
@@ -76,7 +76,8 @@ class ConnectionManager {
}
String getKeyColumnName(ConnectionConfiguration connectionConfig, String tableName) {
- return tableToPrimaryKeyMap.computeIfAbsent(tableName, k -> computeKeyColumnName(connectionConfig, k));
+ return tableToPrimaryKeyMap.computeIfAbsent(tableName,
+ k -> computeKeyColumnName(connectionConfig, k));
}
ConnectionConfiguration getConnectionConfig(String connectionConfigName) {
@@ -84,7 +85,7 @@ class ConnectionManager {
}
PreparedStatement getPreparedStatement(Connection connection, List<ColumnValue> columnList,
- String tableName, Operation operation, int pdxTypeId) {
+ String tableName, Operation operation, int pdxTypeId) {
PreparedStatementCache statementCache = preparedStatementCache.get();
if (statementCache == null) {
@@ -114,7 +115,7 @@ class ConnectionManager {
}
private List<ColumnValue> createColumnValueList(RegionMapping regionMapping, PdxInstance value,
- String keyColumnName) {
+ String keyColumnName) {
List<ColumnValue> result = new ArrayList<>();
for (String fieldName : value.getFieldNames()) {
String columnName = regionMapping.getColumnNameForField(fieldName);
diff --git a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java
index c61a9db..b73698c 100644
--- a/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java
+++ b/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java
@@ -57,7 +57,8 @@ public class SqlHandler {
return executeReadStatement(statement, columnList, factory, regionMapping, keyColumnName);
}
- private <K, V> PdxInstanceFactory getPdxInstanceFactory(Region<K, V> region, RegionMapping regionMapping) {
+ private <K, V> PdxInstanceFactory getPdxInstanceFactory(Region<K, V> region,
+ RegionMapping regionMapping) {
InternalCache cache = (InternalCache) region.getRegionService();
String valueClassName = regionMapping.getPdxClassName();
PdxInstanceFactory factory;
diff --git a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java
index cca2bec..8c290b7 100644
--- a/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java
+++ b/geode-connectors/src/test/java/org/apache/geode/connectors/jdbc/internal/xml/ElementTypeTest.java
@@ -75,7 +75,8 @@ public class ElementTypeTest {
@Test
public void gettingElementTypeThatDoesNotExistThrowsException() {
- assertThatThrownBy(() -> ElementType.getTypeFromName("non-existant element")).isInstanceOf(IllegalArgumentException.class);
+ assertThatThrownBy(() -> ElementType.getTypeFromName("non-existant element"))
+ .isInstanceOf(IllegalArgumentException.class);
}
@Test
--
To stop receiving notification emails like this one, please contact
"commits@geode.apache.org" <co...@geode.apache.org>.
[geode] 01/02: Move geode-connectors further up
Posted by kl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
klund pushed a commit to branch feature/GEODE-3781
in repository https://gitbox.apache.org/repos/asf/geode.git
commit b85f75637a49dd6e10a21857a2038b48141e62e3
Author: Kirk Lund <kl...@apache.org>
AuthorDate: Fri Nov 17 10:44:04 2017 -0800
Move geode-connectors further up
---
settings.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/settings.gradle b/settings.gradle
index 9cbad6d..ef28549 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -30,6 +30,7 @@ include 'geode-lucene'
include 'geode-old-client-support'
include 'geode-wan'
include 'geode-cq'
+include 'geode-connectors'
include 'geode-benchmarks'
include 'extensions/geode-modules'
include 'extensions/geode-modules-tomcat7'
@@ -40,7 +41,6 @@ include 'extensions/geode-modules-assembly'
include 'geode-protobuf'
include 'extensions/session-testing-war'
include 'geode-concurrency-test'
-include 'geode-connectors'
if (GradleVersion.current() < GradleVersion.version(minimumGradleVersion)) {
throw new GradleException('Running with unsupported Gradle Version. Use Gradle Wrapper or with Gradle version >= ' + minimumGradleVersion)
--
To stop receiving notification emails like this one, please contact
"commits@geode.apache.org" <co...@geode.apache.org>.