You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:01:02 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
gaoyunhaii opened a new pull request #19211:
URL: https://github.com/apache/flink/pull/19211
## What is the purpose of the change
This PR updates the Chinese document of Elasticsearch connector to keep consistent with the Engish version.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackergin commented on a change in pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
hackergin commented on a change in pull request #19211:
URL: https://github.com/apache/flink/pull/19211#discussion_r833519406
##########
File path: docs/content.zh/docs/connectors/table/elasticsearch.md
##########
@@ -130,11 +130,28 @@ CREATE TABLE myUserTable (
<td>用于连接 Elasticsearch 实例的密码。如果配置了<code>username</code>，则此选项也必须配置为非空字符串。</td>
</tr>
<tr>
- <td><h5>sink.delivery-guarantee</h5></td>
- <td>可选</td>
- <td style="word-wrap: break-word;">NONE</td>
+ <td><h5>failure-handler</h5></td>
+ <td>optional</td>
+ <td>yes</td>
+ <td style="word-wrap: break-word;">fail</td>
<td>String</td>
- <td>提交时可选的传输保障策略。有效值为 <code>NONE</code> 或者 <code>AT_LEAST_ONCE</code>。</td>
+ <td>对 Elasticsearch 请求失败情况下的失败处理策略。有效策略为：
+ <ul>
+ <li><code>fail</code>：如果请求失败并因此导致作业失败，则抛出异常。</li>
+ <li><code>ignore</code>：忽略失败并放弃请求。</li>
+ <li><code>retry-rejected</code>：重新添加由于队列容量饱和而失败的请求。</li>
+ <li>自定义类名称：使用 ActionRequestFailureHandler 的子类进行失败处理。</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.flush-on-checkpoint</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>在进行 checkpoint 时是否保证刷出缓冲区中的数据。如果关闭这一选项，在进行checkpoint时 sink 将不再为所有进行
Review comment:
```suggestion
<td>在进行 checkpoint 时是否保证刷出缓冲区中的数据。如果关闭这一选项，在进行 checkpoint 时 sink 将不再为所有进行
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19211:
URL: https://github.com/apache/flink/pull/19211#issuecomment-1075996968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b6a339385788d6219fffc7f1eaeb6be5b1a4026 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #19211:
URL: https://github.com/apache/flink/pull/19211#issuecomment-1075994936
Hi @KarmaGYZ Could you have a look at this Chinese document change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19211:
URL: https://github.com/apache/flink/pull/19211#issuecomment-1075996968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33640",
"triggerID" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b6a339385788d6219fffc7f1eaeb6be5b1a4026 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #19211:
URL: https://github.com/apache/flink/pull/19211#discussion_r834911346
##########
File path: docs/content.zh/docs/connectors/table/elasticsearch.md
##########
@@ -130,11 +130,28 @@ CREATE TABLE myUserTable (
<td>用于连接 Elasticsearch 实例的密码。如果配置了<code>username</code>，则此选项也必须配置为非空字符串。</td>
</tr>
<tr>
- <td><h5>sink.delivery-guarantee</h5></td>
- <td>可选</td>
- <td style="word-wrap: break-word;">NONE</td>
+ <td><h5>failure-handler</h5></td>
+ <td>optional</td>
+ <td>yes</td>
+ <td style="word-wrap: break-word;">fail</td>
<td>String</td>
- <td>提交时可选的传输保障策略。有效值为 <code>NONE</code> 或者 <code>AT_LEAST_ONCE</code>。</td>
+ <td>对 Elasticsearch 请求失败情况下的失败处理策略。有效策略为：
+ <ul>
+ <li><code>fail</code>：如果请求失败并因此导致作业失败，则抛出异常。</li>
+ <li><code>ignore</code>：忽略失败并放弃请求。</li>
+ <li><code>retry-rejected</code>：重新添加由于队列容量饱和而失败的请求。</li>
+ <li>自定义类名称：使用 ActionRequestFailureHandler 的子类进行失败处理。</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.flush-on-checkpoint</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>在进行 checkpoint 时是否保证刷出缓冲区中的数据。如果关闭这一选项，在进行checkpoint时 sink 将不再为所有进行
Review comment:
Hi @hackergin the space is required to separate between Chinese and English words (https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #19211:
URL: https://github.com/apache/flink/pull/19211#issuecomment-1078599719
Thanks @KarmaGYZ @hackergin for the review! Will merge~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19211:
URL: https://github.com/apache/flink/pull/19211#issuecomment-1075996968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33640",
"triggerID" : "9b6a339385788d6219fffc7f1eaeb6be5b1a4026",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b6a339385788d6219fffc7f1eaeb6be5b1a4026 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #19211:
URL: https://github.com/apache/flink/pull/19211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #19211: [FLINK-26638][connectors/elasticsearch] update the Chinese document accordingly
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #19211:
URL: https://github.com/apache/flink/pull/19211#discussion_r834911346
##########
File path: docs/content.zh/docs/connectors/table/elasticsearch.md
##########
@@ -130,11 +130,28 @@ CREATE TABLE myUserTable (
<td>用于连接 Elasticsearch 实例的密码。如果配置了<code>username</code>，则此选项也必须配置为非空字符串。</td>
</tr>
<tr>
- <td><h5>sink.delivery-guarantee</h5></td>
- <td>可选</td>
- <td style="word-wrap: break-word;">NONE</td>
+ <td><h5>failure-handler</h5></td>
+ <td>optional</td>
+ <td>yes</td>
+ <td style="word-wrap: break-word;">fail</td>
<td>String</td>
- <td>提交时可选的传输保障策略。有效值为 <code>NONE</code> 或者 <code>AT_LEAST_ONCE</code>。</td>
+ <td>对 Elasticsearch 请求失败情况下的失败处理策略。有效策略为：
+ <ul>
+ <li><code>fail</code>：如果请求失败并因此导致作业失败，则抛出异常。</li>
+ <li><code>ignore</code>：忽略失败并放弃请求。</li>
+ <li><code>retry-rejected</code>：重新添加由于队列容量饱和而失败的请求。</li>
+ <li>自定义类名称：使用 ActionRequestFailureHandler 的子类进行失败处理。</li>
+ </ul>
+ </td>
+ </tr>
+ <tr>
+ <td><h5>sink.flush-on-checkpoint</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">true</td>
+ <td>Boolean</td>
+ <td>在进行 checkpoint 时是否保证刷出缓冲区中的数据。如果关闭这一选项，在进行checkpoint时 sink 将不再为所有进行
Review comment:
Hi @hackergin the space should be required to separate between Chinese and English words (https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org