[GitHub] [zookeeper] eolivelli commented on a change in pull request #1193: ZOOKEEPER-3663: Clean Up ZNodeName Class

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1193: ZOOKEEPER-3663: Clean Up ZNodeName Class
URL: https://github.com/apache/zookeeper/pull/1193#discussion_r361193972
 
 

 ##########
 File path: zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/ZNodeName.java
 ##########
 @@ -102,9 +125,9 @@ public String getName() {
     }
 
     /**
-     * Returns the sequence number.
+     * Returns the optional sequence number.
      */
-    public int getZNodeName() {
+    public Optional<Integer> getSequence() {
 
 Review comment:
   it looks like this method is called only in tests.
   you can drop the 'public' modifier

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services